[Bug python/28533] New: dont_repeat in gdb.Command doesn't have any effect anymore

[Bug python/28533] New: dont_repeat in gdb.Command doesn't have any effect anymore

[plasmahh at gmx dot net]

https://sourceware.org/bugzilla/show_bug.cgi?id=28533

            Bug ID: 28533
           Summary: dont_repeat in gdb.Command doesn't have any effect
                    anymore
           Product: gdb
           Version: HEAD
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: python
          Assignee: unassigned at sourceware dot org
          Reporter: plasmahh at gmx dot net
  Target Milestone: ---

Created attachment 13753
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13753&action=edit
file to source

Tried with dac784d0e4c today. In the past there has been an issue with
dont_repeat not properly working when you did somewhere a gdb.execute() but for
a while now I can't get it to work in any circumstance.

source the attached script (with a gdb started with -nh or so), then do e.g.
"testcommand some args" and then hit enter and it will be called again, but due
to the dont_repeat I expect it not to be.

PS: It would be cool if there was a regression test for this ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug python/28533] dont_repeat in gdb.Command doesn't have any effect anymore

[ssbssa at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28533

Hannes Domani <ssbssa at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ssbssa at sourceware dot org

--- Comment #1 from Hannes Domani <ssbssa at sourceware dot org> ---
In your testcommand you called self.dont_repeat() in __init__(), but you need
to call it invoke().
Maybe that should be made clearer in the docu.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug python/28533] dont_repeat in gdb.Command doesn't have any effect anymore

[plasmahh at gmx dot net]

https://sourceware.org/bugzilla/show_bug.cgi?id=28533

--- Comment #2 from Dennis Lubert <plasmahh at gmx dot net> ---
Hm, intresting. After in the past there was a bug fixed I was under the
impression that this is a general "flag" to be set or similar in __init__.
Neither behaviour could be read from the documentation and I think this should
be changed, so this ticket is probably for that then.

It would be nice if the documentation then tells something about how and if it
interacts with any gdb.execute() invocations that themselves could invoke
dont_repeat indirectly. Or in other words if dont_repeat should be the last
thing bevore returning from invoke() or if it doesn't matter when it is called.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug python/28533] dont_repeat in gdb.Command doesn't have any effect anymore

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28533

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org
   Last reconfirmed|                            |2022-02-19
                 CC|                            |tromey at sourceware dot org
     Ever confirmed|0                           |1

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
I have a doc patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug python/28533] dont_repeat in gdb.Command doesn't have any effect anymore

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28533

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=285dfa0f6877ea7677e84c3c1001c5d339fbbe5e

commit 285dfa0f6877ea7677e84c3c1001c5d339fbbe5e
Author: Tom Tromey <tom@tromey.com>
Date:   Sat Feb 19 09:33:12 2022 -0700

    Add to documentation of Python 'dont_repeat' method

    PR python/28533 points out that the Python 'dont_repeat' documentation
    is a bit ambiguous about when the method ought to be called.  This
    patch spells it out.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug python/28533] dont_repeat in gdb.Command doesn't have any effect anymore

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28533

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |13.1
         Resolution|---                         |FIXED

--- Comment #5 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.