public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "fredrik.hederstierna@securitas-direct.com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/28549] ARM/Cortex-M: improper stack unwinding when the target is in lockup state
Date: Fri, 05 Nov 2021 15:43:20 +0000	[thread overview]
Message-ID: <bug-28549-4717-pKWeFzGFIs@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-28549-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=28549

--- Comment #4 from Fredrik Hederstierna <fredrik.hederstierna@securitas-direct.com> ---
I agree it might be some mixups between LR and PC, though I think in practice
it might not cause any problems in these cases.

To cover also Cortex-M33 ARMv8M maybe also check for LR=0xFFFFFFFE and
PC=0xEFFFFFFE. The 'easy' fix is to add these values I guess:

diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
index 857a52a9a51..33b03ead5a4 100644
--- a/gdb/arm-tdep.c
+++ b/gdb/arm-tdep.c
@@ -556,6 +556,13 @@ arm_m_addr_is_magic (CORE_ADDR addr)
       case 0xfffffff1:
       case 0xfffffff9:
       case 0xfffffffd:
+      /* Values for Lockup state.
+       For more details see "B1.5.15 Unrecoverable exception cases" in
+       both ARMv6-M and ARMv7-M Architecture Reference Manuals, or
+        see "B4.32 Lockup" in ARMv8-M Architecture Reference Manual.  */
+      case 0xeffffffe:
+      case 0xfffffffe:
+      case 0xffffffff:
        /* Address is magic.  */
        return 1;

Though maybe we would like to add some more info that actually detects more
explicit the LOCKUP state and make some printouts about that?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-11-05 15:43 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-05  9:51 [Bug gdb/28549] New: " tarek.bouchkati at gmail dot com
2021-11-05 10:34 ` [Bug gdb/28549] " tarek.bouchkati at gmail dot com
2021-11-05 10:59 ` tarek.bouchkati at gmail dot com
2021-11-05 12:26 ` tarek.bouchkati at gmail dot com
2021-11-05 12:36 ` tarek.bouchkati at gmail dot com
2021-11-05 13:16 ` alahay01 at gcc dot gnu.org
2021-11-05 13:22 ` luis.machado at linaro dot org
2021-11-05 14:02 ` luis.machado at linaro dot org
2021-11-05 14:02 ` luis.machado at linaro dot org
2021-11-05 15:43 ` fredrik.hederstierna@securitas-direct.com [this message]
2021-11-05 15:51 ` tarek.bouchkati at gmail dot com
2021-11-05 23:14 ` fredrik.hederstierna@securitas-direct.com
2021-11-05 23:25 ` fredrik.hederstierna@securitas-direct.com
2021-11-06  0:20 ` fredrik.hederstierna@securitas-direct.com
2021-11-15 12:04 ` tarek.bouchkati at gmail dot com
2021-11-15 12:52 ` luis.machado at linaro dot org
2021-11-15 13:15 ` tarek.bouchkati at gmail dot com
2021-11-15 18:09 ` fredrik.hederstierna@securitas-direct.com
2021-11-15 18:46 ` luis.machado at linaro dot org
2021-11-18 11:18 ` tarek.bouchkati at gmail dot com
2021-12-10 12:30 ` tomas.vanek at fbl dot cz
2021-12-13  8:30 ` luis.machado at linaro dot org
2021-12-13  9:55 ` tomas.vanek at fbl dot cz
2021-12-13 10:07 ` clyon at gcc dot gnu.org
2021-12-13 10:35 ` luis.machado at linaro dot org
2021-12-13 10:37 ` luis.machado at linaro dot org
2021-12-13 20:22 ` tomas.vanek at fbl dot cz
2021-12-13 21:48 ` fredrik.hederstierna@securitas-direct.com
2021-12-13 22:00 ` fredrik.hederstierna@securitas-direct.com
2021-12-14  0:09 ` tomas.vanek at fbl dot cz
2021-12-14  0:33 ` tomas.vanek at fbl dot cz
2021-12-14 10:27 ` tomas.vanek at fbl dot cz
2021-12-14 14:42 ` tomas.vanek at fbl dot cz
2021-12-14 14:45 ` tomas.vanek at fbl dot cz
2021-12-14 14:50 ` tomas.vanek at fbl dot cz
2021-12-15 16:44 ` luis.machado at linaro dot org
2021-12-15 16:56 ` fredrik.hederstierna@securitas-direct.com
2021-12-15 17:42 ` tomas.vanek at fbl dot cz
2022-01-19 11:34 ` tarek.bouchkati at gmail dot com
2022-01-19 11:35 ` luis.machado at linaro dot org
2022-01-19 11:36 ` luis.machado at linaro dot org
2022-01-19 11:40 ` clyon at gcc dot gnu.org
2022-01-19 12:18 ` tarekbouchkati at gmail dot com
2022-09-09  8:25 ` luis.machado at arm dot com
2022-09-09 23:35 ` fredrik.hederstierna@securitas-direct.com
2022-09-10  7:27 ` luis.machado at arm dot com
2022-09-11 13:59 ` tomas.vanek at fbl dot cz
2022-09-12  9:32 ` luis.machado at arm dot com
2022-09-14  9:07 ` tomas.vanek at fbl dot cz
2022-09-14 12:10 ` luis.machado at arm dot com
2022-10-02  7:13 ` torbjorn.svensson at st dot com
2022-10-02  7:18 ` tomas.vanek at fbl dot cz
2022-10-06 13:07 ` luis.machado at arm dot com
2022-10-11  8:08 ` torbjorn.svensson at st dot com
2022-10-14 14:07 ` torbjorn.svensson at st dot com
2022-10-16 12:24 ` tomas.vanek at fbl dot cz
2022-10-21 10:01 ` luis.machado at arm dot com
2022-10-29 18:40 ` brobecker at gnat dot com
2022-10-31 10:18 ` luis.machado at arm dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-28549-4717-pKWeFzGFIs@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).