[Bug server/28627] New: remote.c:8318: internal-error: wait: Assertion `!async_event_handler_marked (rs->remote_async_inferior_event_token)' failed

[Bug server/28627] New: remote.c:8318: internal-error: wait: Assertion `!async_event_handler_marked (rs->remote_async_inferior_event_token)' failed

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28627

            Bug ID: 28627
           Summary: remote.c:8318: internal-error: wait: Assertion
                    `!async_event_handler_marked
                    (rs->remote_async_inferior_event_token)' failed
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: server
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

In more detail:
...
(gdb) PASS: gdb.server/attach-flag.exp: non-stop=0: target-non-stop=1: maint
set target-non-stop 1
target remote localhost:2376^M
Remote debugging using localhost:2376^M
/home/vries/gdb_versions/devel/src/gdb/remote.c:8318: internal-error: wait:
Assertion `!async_event_handler_marked (rs->remote_async_inferior_event_token)'
failed.^M
A problem internal to GDB has been detected,^M
further debugging may prove unreliable.^M
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/28627] remote.c:8318: internal-error: wait: Assertion `!async_event_handler_marked (rs->remote_async_inferior_event_token)' failed

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28627

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
The assert was introduced recently:
...
commit 32b1f5e8d6b8ddd3be6e471c26dd85a1dac31dda
Author: Andrew Burgess <aburgess@redhat.com>
Date:   Mon Nov 22 12:30:36 2021 +0000

    gdb: add assert in remote_target::wait relating to async being off
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/28627] remote.c:8318: internal-error: wait: Assertion `!async_event_handler_marked (rs->remote_async_inferior_event_token)' failed

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28627

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
Created attachment 13805
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13805&action=edit
gdb.log

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/28627] remote.c:8318: internal-error: wait: Assertion `!async_event_handler_marked (rs->remote_async_inferior_event_token)' failed

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28627

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
Triggers 21 times in a full test run:
...
$ grep -a internal-error: gdb.log | grep -v maint.c | wc -l
21
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/28627] remote.c:8318: internal-error: wait: Assertion `!async_event_handler_marked (rs->remote_async_inferior_event_token)' failed

[aburgess at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28627

Andrew Burgess <aburgess at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
                 CC|                            |aburgess at redhat dot com

--- Comment #4 from Andrew Burgess <aburgess at redhat dot com> ---
Apologies for the regression.  I've reverted the offending patch.

Longer story: I pushed part of a patch series, the last, unpushed, patch fixes
this issue - I double checked my results and definitely don't see that assert
when using the full series.

I should have retested the partial series before pushing it, I didn't, and it
caught me out this time.  I'll make sure I test before pushing parts of a
series in future.

-- 
You are receiving this mail because:
You are on the CC list for the bug.