public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug symtab/28644] New: [fission] FAIL: gdb.base/include-main.exp: list include-main.c:18
@ 2021-12-02 12:45 vries at gcc dot gnu.org
  2021-12-02 12:49 ` [Bug symtab/28644] " vries at gcc dot gnu.org
  0 siblings, 1 reply; 2+ messages in thread
From: vries at gcc dot gnu.org @ 2021-12-02 12:45 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=28644

            Bug ID: 28644
           Summary: [fission] FAIL: gdb.base/include-main.exp: list
                    include-main.c:18
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: symtab
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

When running test-case gdb.base/include-main.exp with target board fission, we
run into:
...
(gdb) PASS: gdb.base/include-main.exp: maint info symtab
list include-main.c:18^M
No source file named include-main.c.^M
(gdb) FAIL: gdb.base/include-main.exp: list include-main.c:18
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Bug symtab/28644] [fission] FAIL: gdb.base/include-main.exp: list include-main.c:18
  2021-12-02 12:45 [Bug symtab/28644] New: [fission] FAIL: gdb.base/include-main.exp: list include-main.c:18 vries at gcc dot gnu.org
@ 2021-12-02 12:49 ` vries at gcc dot gnu.org
  0 siblings, 0 replies; 2+ messages in thread
From: vries at gcc dot gnu.org @ 2021-12-02 12:49 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=28644

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
This tentative patch fixes the test-case:
...
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index 57538fc0adf..04c258d1aef 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -3084,7 +3084,7 @@ dw2_get_file_names (dwarf2_per_cu_data *this_cu,
   if (this_cu->v.quick->files_read)
     return this_cu->v.quick->file_names;

-  cutu_reader reader (this_cu, per_objfile);
+  cutu_reader reader (this_cu, per_objfile, nullptr, nullptr, false);
   if (!reader.dummy_p)
     dw2_get_file_names_reader (&reader, reader.comp_unit_die);

...

But it causes regressions:
...
$ grep "unexpected failures" fission/gdb.sum fission-patched/gdb.sum 
fission/gdb.sum:# of unexpected failures        96
fission-patched/gdb.sum:# of unexpected failures        4436
...

F.i.:
...
-PASS: gdb.base/callfuncs.exp: rerun number 1: set language c
+FAIL: gdb.base/callfuncs.exp: rerun number 1: set language c
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-02 12:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-02 12:45 [Bug symtab/28644] New: [fission] FAIL: gdb.base/include-main.exp: list include-main.c:18 vries at gcc dot gnu.org
2021-12-02 12:49 ` [Bug symtab/28644] " vries at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).