public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "simark at simark dot ca" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/28681] Wrong pretty-printed unique_ptr value when using "finish"
Date: Tue, 14 Dec 2021 13:52:24 +0000	[thread overview]
Message-ID: <bug-28681-4717-y53jawCuZj@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-28681-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=28681

--- Comment #6 from Simon Marchi <simark at simark dot ca> ---
> And it is when we ask for the loc_bitpos that the assert triggers, as the
> field's type is no FIELD_LOC_KIND_BITPOS, but is instead,
> FIELD_LOC_KIND_DWARF_BLOCK.
> 
> In the case we're handling, the field being processed is the field that
> describes the virtual base of the type being processed.
> 
> I originally starting playing with is_dynamic_type, but noticed that the
> type in question doesn't return true for is_dynamic_type.  This seemed
> weird, as clearly the offset needs resolving.  But then I found some code in
> is_dynamic_type_internal which specifically detects the exact case I'm
> looking at, and ensures that such a case is NOT enough to make a type appear
> dynamic.  The comment on this code says:
> 
> 	    /* Do not consider C++ virtual base types to be dynamic
> 	       due to the field's offset being dynamic; these are
> 	       handled via other means.  */
> 
> But, frustratingly, doesn't indicate what that other means is, or where I
> might find it.

Ok, it is that issue I was curious about.  It sounds similar to this, but at a
different place:

https://sourceware.org/pipermail/gdb-patches/2021-September/182307.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-12-14 13:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10 17:02 [Bug gdb/28681] New: " simark at simark dot ca
2021-12-12 17:05 ` [Bug gdb/28681] " ssbssa at sourceware dot org
2021-12-13 16:37 ` aburgess at redhat dot com
2021-12-13 16:50 ` aburgess at redhat dot com
2021-12-13 17:31 ` aburgess at redhat dot com
2021-12-13 18:22 ` simark at simark dot ca
2021-12-14  9:50 ` aburgess at redhat dot com
2021-12-14 13:52 ` simark at simark dot ca [this message]
2021-12-15 17:39 ` aburgess at redhat dot com
2021-12-23 12:15 ` cvs-commit at gcc dot gnu.org
2021-12-23 12:16 ` aburgess at redhat dot com
2021-12-23 13:05 ` simon.marchi at polymtl dot ca
2022-03-14 10:39 ` cvs-commit at gcc dot gnu.org
2022-11-14 21:23 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-28681-4717-y53jawCuZj@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).