[Bug gdb/29032] [gdb][test-case failure, taskset] FAIL: gdb.base/eof-exit.exp: with non-dump terminal: close GDB with eof (timeout)

["aburgess at redhat dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29032

--- Comment #8 from Andrew Burgess <aburgess at redhat dot com> ---
This also feels like an issue with readline's callback api.  I wonder if we
should (in parallel) be reporting this issue upstream?

Pretty much untested, this patch seems to "fix" readline:

diff --git a/readline/readline/readline.c b/readline/readline/readline.c
index e61d188bbe9..1306ac7873d 100644
--- a/readline/readline/readline.c
+++ b/readline/readline/readline.c
@@ -630,7 +630,7 @@ readline_internal_charloop (void)
         previous character is interpreted as EOF.  This doesn't work when
         READLINE_CALLBACKS is defined, so hitting a series of ^Ds will
         erase all the chars on the line and then return EOF. */
-      if (((c == _rl_eof_char && lastc != c) || c == EOF) && rl_end == 0)
+      if (((c == _rl_eof_char && lastc != c) || c == EOF || c == 0) && rl_end
== 0)
        {
 #if defined (READLINE_CALLBACKS)
          RL_SETSTATE(RL_STATE_DONE);


But I understand that we might want a solution in GDB (as well) that doesn't
tie us to a particular readline release.  I happy to take this to the readline
list, but I'd value your thoughts before I did.

-- 
You are receiving this mail because:
You are on the CC list for the bug.