public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "tromey at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/29106] new DWARF reader should de-duplicate functions
Date: Fri, 23 Sep 2022 19:38:29 +0000	[thread overview]
Message-ID: <bug-29106-4717-EUp71rIlZF@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29106-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29106

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
Further searching shows that the second CU in question has:

 <1><d94e58>: Abbrev Number: 24 (DW_TAG_subprogram)
    <d94e59>   DW_AT_specification: <0xd5c48b>
    <d94e5d>   DW_AT_object_pointer: <0xd94e77>
    <d94e61>   DW_AT_low_pc      : 0x0
    <d94e69>   DW_AT_high_pc     : 0x28
    <d94e71>   DW_AT_frame_base  : 1 byte block: 9c     (DW_OP_call_frame_cfa)
    <d94e73>   DW_AT_call_all_tail_calls: 1
    <d94e73>   DW_AT_sibling     : <0xd94e84>

The new index seems more correct to me, and in particular the
old gdb index does:

(gdb) break intrusive_list<inferior, intrusive_base_node<inferior> >::begin()
const
Breakpoint 1 at 0x4ac474: intrusive_list<inferior,
intrusive_base_node<inferior> >::begin() const. (4 locations)


Whereas with the new index we get:

(gdb) break intrusive_list<inferior, intrusive_base_node<inferior> >::begin()
const
Breakpoint 1 at 0x4ac474: intrusive_list<inferior,
intrusive_base_node<inferior> >::begin() const. (58 locations)

So I tend to think the old gdb was missing some locations.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2022-09-23 19:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29 19:52 [Bug symtab/29106] New: " tromey at sourceware dot org
2022-04-29 20:09 ` [Bug symtab/29106] " tromey at sourceware dot org
2022-05-13 14:20 ` tromey at sourceware dot org
2022-07-13 16:49 ` tromey at sourceware dot org
2022-09-23 17:48 ` tromey at sourceware dot org
2022-09-23 19:38 ` tromey at sourceware dot org [this message]
2022-09-23 19:44 ` tromey at sourceware dot org
2022-09-23 20:45 ` tromey at sourceware dot org
2022-10-18 18:31 ` tromey at sourceware dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29106-4717-EUp71rIlZF@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).