public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "tromey at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/29106] New: new DWARF reader should de-duplicate functions
Date: Fri, 29 Apr 2022 19:52:44 +0000	[thread overview]
Message-ID: <bug-29106-4717@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=29106

            Bug ID: 29106
           Summary: new DWARF reader should de-duplicate functions
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: symtab
          Assignee: unassigned at sourceware dot org
          Reporter: tromey at sourceware dot org
  Target Milestone: ---

In https://sourceware.org/pipermail/gdb-patches/2022-April/188400.html,
Pedro pointed out that, even with the patch in that thread,
the new DWARF reader still generates a larger index:

In the old indexer, with an index of a gdb from before the indexer rewrite, we
had:

 [369902] intrusive_list<inferior, intrusive_base_node<inferior> >::begin:
          9 [global, function]
          255 [global, function]

while in the new indexer, for the same function, we have:

 [369902] intrusive_list<inferior, intrusive_base_node<inferior> >::begin:
         9 [global, function]
         79 [global, function]
         165 [global, function]
         167 [global, function]
[ ... many more instances ... ]

I suspect this is due to the old handling of DW_AT_inline.
See https://sourceware.org/pipermail/gdb-patches/2022-April/188557.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2022-04-29 19:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29 19:52 tromey at sourceware dot org [this message]
2022-04-29 20:09 ` [Bug symtab/29106] " tromey at sourceware dot org
2022-05-13 14:20 ` tromey at sourceware dot org
2022-07-13 16:49 ` tromey at sourceware dot org
2022-09-23 17:48 ` tromey at sourceware dot org
2022-09-23 19:38 ` tromey at sourceware dot org
2022-09-23 19:44 ` tromey at sourceware dot org
2022-09-23 20:45 ` tromey at sourceware dot org
2022-10-18 18:31 ` tromey at sourceware dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29106-4717@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).