[Bug build/29110] New: Build failure for x86_64-w64-mingw32 GCC 13 host (because of win32 thread model?)

[Bug build/29110] New: Build failure for x86_64-w64-mingw32 GCC 13 host (because of win32 thread model?)

[euloanty at live dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29110

            Bug ID: 29110
           Summary: Build failure for x86_64-w64-mingw32 GCC 13 host
                    (because of win32 thread model?)
           Product: gdb
           Version: HEAD
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: euloanty at live dot com
  Target Milestone: ---

Created attachment 14088
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14088&action=edit
build failure

gcc with win32 thread model does not correctly support C++11 threads. The build
just fails.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/29110] Build failure for x86_64-w64-mingw32 GCC 13 host (because of win32 thread model?)

[euloanty at live dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29110

cqwrteur <euloanty at live dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |x86_64-w64-mingw32
               Host|                            |x86_64-w64-mingw32
                 CC|                            |euloanty at live dot com
              Build|                            |x86_64-linux-gnu

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/29110] Build failure for x86_64-w64-mingw32 GCC 13 host (because of win32 thread model?)

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29110

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
What version of gcc are you using?

When I do a build using the Fedora mingw cross toolchain, it works fine,
and AFAIK this gcc also doesn't support win32 threads.
My version is:

murgatroyd. x86_64-w64-mingw32-gcc --version
x86_64-w64-mingw32-gcc (GCC) 10.3.1 20210422 (Fedora MinGW 10.3.1-2.fc34)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/29110] Build failure for x86_64-w64-mingw32 GCC 13 host (because of win32 thread model?)

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29110

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-05-07

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/29110] Build failure for x86_64-w64-mingw32 GCC 13 host (because of win32 thread model?)

[euloanty at live dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29110

--- Comment #2 from cqwrteur <euloanty at live dot com> ---
(In reply to Tom Tromey from comment #1)
> What version of gcc are you using?
> 
> When I do a build using the Fedora mingw cross toolchain, it works fine,
> and AFAIK this gcc also doesn't support win32 threads.
> My version is:
> 
> murgatroyd. x86_64-w64-mingw32-gcc --version
> x86_64-w64-mingw32-gcc (GCC) 10.3.1 20210422 (Fedora MinGW 10.3.1-2.fc34)

GCC 13. You are probably using POSIX thread model. I am using win32 thread
model that does not provide C++ thread or even mutex facility at all for
libstdc++

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/29110] Build failure for x86_64-w64-mingw32 GCC 13 host (because of win32 thread model?)

[euloanty at live dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29110

--- Comment #3 from cqwrteur <euloanty at live dot com> ---
(In reply to Tom Tromey from comment #1)
> What version of gcc are you using?
> 
> When I do a build using the Fedora mingw cross toolchain, it works fine,
> and AFAIK this gcc also doesn't support win32 threads.
> My version is:
> 
> murgatroyd. x86_64-w64-mingw32-gcc --version
> x86_64-w64-mingw32-gcc (GCC) 10.3.1 20210422 (Fedora MinGW 10.3.1-2.fc34)

cqwrteur@Home-Server:~/fast_io_cleanup/fast_io/benchmark/0002.file_io_tsc/time$
x86_64-w64-mingw32-g++ -v
Using built-in specs.
COLLECT_GCC=x86_64-w64-mingw32-g++
COLLECT_LTO_WRAPPER=/home/cqwrteur/toolchains/gnu/native/x86_64-w64-mingw32/libexec/gcc/x86_64-w64-mingw32/13.0.0/lto-wrapper
Target: x86_64-w64-mingw32
Configured with: ../../../../gcc/configure --disable-nls --disable-werror
--target=x86_64-w64-mingw32
--prefix=/home/cqwrteur/toolchains/gnu/native/x86_64-w64-mingw32
--disable-libstdcxx-verbose
--with-gxx-libcxx-include-dir=/home/cqwrteur/toolchains/gnu/native/x86_64-w64-mingw32/x86_64-w64-mingw32/include/c++/v1
--enable-languages=c,c++ --disable-sjlj-exceptions
Thread model: win32
Supported LTO compression algorithms: zlib zstd
gcc version 13.0.0 20220501 (experimental) (GCC)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/29110] Build failure for x86_64-w64-mingw32 GCC 13 host (because of win32 thread model?)

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29110

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org
             Status|WAITING                     |NEW

--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
That does seem to be the issue, I have:

Thread model: posix

I don't think I realized there were different models like this,
with different properties -- I thought that the basics were
the same everywhere and that just threads didn't work.

Anyway, what does this show on your gdb build?

murgatroyd. grep CXX_STD_THREAD gdbsupport/config.h 
#define CXX_STD_THREAD 1

I'm wondering if the configure check can be relied on.

Patching around this might be a bit of a pain but it can be done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/29110] Build failure for x86_64-w64-mingw32 GCC 13 host (because of win32 thread model?)

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29110

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING

--- Comment #5 from Tom Tromey <tromey at sourceware dot org> ---
Please try

https://sourceware.org/pipermail/gdb-patches/2022-May/188871.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/29110] Build failure for x86_64-w64-mingw32 GCC 13 host (because of win32 thread model?)

[euloanty at live dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29110

--- Comment #6 from cqwrteur <euloanty at live dot com> ---
(In reply to Tom Tromey from comment #5)
> Please try
> 
> https://sourceware.org/pipermail/gdb-patches/2022-May/188871.html

Yes it works now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/29110] Build failure for x86_64-w64-mingw32 GCC 13 host (because of win32 thread model?)

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29110

--- Comment #7 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=20c4eb4226997c0de0a47d5d4c6c2eed21ed9af4

commit 20c4eb4226997c0de0a47d5d4c6c2eed21ed9af4
Author: Tom Tromey <tromey@adacore.com>
Date:   Mon May 9 11:48:40 2022 -0600

    Fix --disable-threading build

    PR build/29110 points out that GDB fails to build on mingw when the
    "win32" thread model is in use.  It turns out that the Fedora cross
    tools using the "posix" thread model, which somehow manages to support
    std::future, whereas the win32 model does not.

    While looking into this, I found that the configuring with
    --disable-threading will also cause a build failure.

    This patch fixes this build by introducing a compatibility wrapper for
    std::future.

    I am not able to test the win32 thread model build, but I'm going to
    ask the reporter to try this patch.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29110

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/29110] Build failure for x86_64-w64-mingw32 GCC 13 host (because of win32 thread model?)

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29110

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |13.1

--- Comment #8 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.