[Bug gdb/29119] New: 32-bit build failure with --enable-targets=all

[Bug gdb/29119] New: 32-bit build failure with --enable-targets=all

[luis.machado at arm dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29119

            Bug ID: 29119
           Summary: 32-bit build failure with --enable-targets=all
           Product: gdb
           Version: 12.1
            Status: NEW
          Severity: normal
          Priority: P2
         Component: gdb
          Assignee: unassigned at sourceware dot org
          Reporter: luis.machado at arm dot com
                CC: tromey at sourceware dot org
  Target Milestone: ---
              Host: *-linux-gnu
            Target: *
             Build: *-linux-gnu

Currently, a 32-bit build of binutils-gdb on Linux doesn't complete if we pass
the --enable-targets=all switch. There are a few problems in the list of files
included for 32-bit bfd and 64-bit bfd.

This ticket aims to track these fixes so we can backport them to GDB 12.1.

>From the top of my head, we have the following:

1 - [opcodes] Move TILE-Gx files from TARGET32_LIBOPCODES_CFILES to
TARGET64_LIBOPCODES_CFILES
(https://sourceware.org/pipermail/binutils/2022-May/120651.html).
2 - [gdb] Move bpf, tile-gx and loongarch files from ALL_TARGET_OBS to
ALL_64_TARGET_OBS
(https://sourceware.org/pipermail/gdb-patches/2022-May/188650.html).
3 - [opcodes] Don't define ARCH_cris for 64-bit BFD, since it is a 32-bit
architecture (https://sourceware.org/pipermail/binutils/2022-May/120662.html).
4 - [sim] There is fallout from moving cris to the 32-bit bfd list that needs
to be addressed in the print formatters.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/29119] 32-bit build failure with --enable-targets=all

[luis.machado at arm dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29119

--- Comment #1 from Luis Machado <luis.machado at arm dot com> ---
Also...

5 - [sim] Enable bpf sim build only if a 64-bit bfd is enabled. Otherwise the
sim won't build properly due to dependencies with libopcodes that won't be
there for 32-bit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/29119] 32-bit build failure with --enable-targets=all

[luis.machado at arm dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29119

--- Comment #2 from Luis Machado <luis.machado at arm dot com> ---
1 and 3 are now pushed to mainline binutils-gdb.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/29119] 32-bit build failure with --enable-targets=all

[luis.machado at arm dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29119

--- Comment #3 from Luis Machado <luis.machado at arm dot com> ---
Pushed 2.

I'm not planning on pursuing 4.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/29119] 32-bit build failure with --enable-targets=all

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29119

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sam at gentoo dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/29119] 32-bit build failure with --enable-targets=all

[luis.machado at arm dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29119

--- Comment #4 from Luis Machado <luis.machado at arm dot com> ---
New commit related to this:

commit 33b90f59f3465041a620ad4f6504a35b578cfc65
Author: Sergei Trofimovich <siarheit@google.com>
Date:   Sat May 21 08:53:50 2022 +0100

    sim: fix BFD_VMA format arguments on 32-bit hosts [PR gdb/29184]

    Noticed format mismatch when attempted to build gdb on i686-linux-gnu
    in --enable-64-bit-bfd mode:

        sim/../../sim/cris/sim-if.c:576:28:
            error: format '%lx' expects argument of type 'long unsigned int',
            but argument 4 has type 'bfd_size_type' {aka 'long long unsigned
int'} [-Werror=format=]
          576 |       sim_do_commandf (sd, "memory region 0x%" BFD_VMA_FMT
"x,0x%lx",
              |                            ^~~~~~~~~~~~~~~~~~~
          577 |          interp_load_addr, interpsiz);
              |                            ~~~~~~~~~
              |                            |
              |                            bfd_size_type {aka long long
unsigned int}

    While at it fixed format string for time-related types.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/29119] 32-bit build failure with --enable-targets=all

[luis.machado at arm dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29119

--- Comment #5 from Luis Machado <luis.machado at arm dot com> ---
Commit 33b90f59f3465041a620ad4f6504a35b578cfc65 is number 4 in the list on the
first comment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/29119] 32-bit build failure with --enable-targets=all

[luis.machado at arm dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29119

--- Comment #6 from Luis Machado <luis.machado at arm dot com> ---
There are still a couple problems:

../../../repos/binutils-gdb/opcodes/vax-dis.c: In function ‘print_insn_vax’:   
                                                            
../../../repos/binutils-gdb/opcodes/vax-dis.c:389:25: error: argument ‘memaddr’
might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
  389 | print_insn_vax (bfd_vma memaddr, disassemble_info *info)

../../../repos/binutils-gdb/opcodes/xtensa-dis.c: In function
‘print_insn_xtensa’:
../../../repos/binutils-gdb/opcodes/xtensa-dis.c:269:28: error: argument
‘memaddr’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
  269 | print_insn_xtensa (bfd_vma memaddr, struct disassemble_info *info)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/29119] 32-bit build failure with --enable-targets=all

[luis.machado at arm dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29119

Luis Machado <luis.machado at arm dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #7 from Luis Machado <luis.machado at arm dot com> ---
Now fixed if built with --enable-64-bit-bfd.

-- 
You are receiving this mail because:
You are on the CC list for the bug.