[Bug symtab/29179] New: [cc-with-gdb-index] FAIL: gdb.ada/O2_float_param.exp: scenario=all: gdb_breakpoint: set breakpoint at increment

[Bug symtab/29179] New: [cc-with-gdb-index] FAIL: gdb.ada/O2_float_param.exp: scenario=all: gdb_breakpoint: set breakpoint at increment

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29179

            Bug ID: 29179
           Summary: [cc-with-gdb-index] FAIL: gdb.ada/O2_float_param.exp:
                    scenario=all: gdb_breakpoint: set breakpoint at
                    increment
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: symtab
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

When running the testsuite with target board cc-with-gdb-index I see a lot of
FAILs.

First one:
...
(gdb) break increment^M
Function "increment" not defined.^M
Make breakpoint pending on future shared library load? (y or [n]) n^M
(gdb) FAIL: gdb.ada/O2_float_param.exp: scenario=all: gdb_breakpoint: set
breakpoint at increment
...

This passes with gdb 12 branch, so this is a regression.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/29179] [cc-with-gdb-index] FAIL: gdb.ada/O2_float_param.exp: scenario=all: gdb_breakpoint: set breakpoint at increment

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29179

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
Bisects to commit 2cf349be0e3 ("Do not put linkage names into .gdb_index")

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/29179] [cc-with-gdb-index] FAIL: gdb.ada/O2_float_param.exp: scenario=all: gdb_breakpoint: set breakpoint at increment

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29179

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
Also observed this with cc-with-gdb-index, may well be related to the same
commit:
...
FAIL: gdb.base/c-linkage-name.exp: print symada__cS before partial symtab
expansion
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/29179] [cc-with-gdb-index] FAIL: gdb.ada/O2_float_param.exp: scenario=all: gdb_breakpoint: set breakpoint at increment

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29179

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29366


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=29366
[Bug 29366] [meta] New DWARF indexer meta bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/29179] [cc-with-gdb-index] FAIL: gdb.ada/O2_float_param.exp: scenario=all: gdb_breakpoint: set breakpoint at increment

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29179

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
The index contains:

[774] callee.increment: 2 [global, function]

but the debug info says:

    <1ab9>   DW_AT_name        : (indirect string, offset: 0x22a4):
callee__increment

Probably we need to do the ada_decode business from
commit 7ab96794115.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/29179] [cc-with-gdb-index] FAIL: gdb.ada/O2_float_param.exp: scenario=all: gdb_breakpoint: set breakpoint at increment

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29179

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org
   Target Milestone|---                         |13.1

--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
Working on a patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/29179] [cc-with-gdb-index] FAIL: gdb.ada/O2_float_param.exp: scenario=all: gdb_breakpoint: set breakpoint at increment

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29179

--- Comment #5 from Tom Tromey <tromey at sourceware dot org> ---
https://sourceware.org/pipermail/gdb-patches/2022-September/192056.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/29179] [cc-with-gdb-index] FAIL: gdb.ada/O2_float_param.exp: scenario=all: gdb_breakpoint: set breakpoint at increment

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29179

--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=5fea97943259a2bd997f92ffa66116b5c0d4eaab

commit 5fea97943259a2bd997f92ffa66116b5c0d4eaab
Author: Tom Tromey <tromey@adacore.com>
Date:   Thu Sep 22 08:43:47 2022 -0600

    Improve Ada support in .gdb_index

    The cooked index work changed how .gdb_index is constructed, and in
    the process broke .gdb_index support.  This is PR symtab/29179.

    This patch partially fixes the problem.  It arranges for Ada names to
    be encoded in the form expected by the index code.  In particular,
    linkage names for Ada are emitted, including the "main" name; names
    are Ada-encoded; and names are no longer case-folded, something that
    prevented operator names from round-tripping correctly.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29179

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/29179] [cc-with-gdb-index] FAIL: gdb.ada/O2_float_param.exp: scenario=all: gdb_breakpoint: set breakpoint at increment

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29179

--- Comment #7 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=dd05fc7071a6517de13975fcddca861547351266

commit dd05fc7071a6517de13975fcddca861547351266
Author: Tom Tromey <tromey@adacore.com>
Date:   Thu Sep 22 13:10:55 2022 -0600

    Change .gdb_index de-duplication implementation

    While investigating PR symtab/29179, I found that one Ada test failed
    because, although a certain symbol was present in the index, with the
    new DWARF reader it pointed to a different CU than was chosen by
    earlier versions of gdb.

    This patch changes how symbol de-duplication is done, deferring the
    process until the entire symbol table has been constructed.  This way,
    it's possible to always choose the lower-numbered CU among duplicates,
    which is how gdb (implicitly) previously worked.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29179

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/29179] [cc-with-gdb-index] FAIL: gdb.ada/O2_float_param.exp: scenario=all: gdb_breakpoint: set breakpoint at increment

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29179

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #8 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.