[Bug sim/29184] New: [PATCH] sim fails to build on 32-bit systems with -Werror=format-security

[Bug sim/29184] New: [PATCH] sim fails to build on 32-bit systems with -Werror=format-security

[slyich at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29184

            Bug ID: 29184
           Summary: [PATCH] sim fails to build on 32-bit systems with
                    -Werror=format-security
           Product: gdb
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: sim
          Assignee: unassigned at sourceware dot org
          Reporter: slyich at gmail dot com
                CC: vapier at gentoo dot org
  Target Milestone: ---

In https://github.com/NixOS/nixpkgs/pull/171216#issuecomment-1133541978
Vladimír Čunát noticed gdb-12.1 build failure on 32-bit systems with
-Werror=format-security

Build of gdb on i686-linux-gnu is in --enable-64-bit-bfd mode:

    sim/../../sim/cris/sim-if.c:576:28:
        error: format '%lx' expects argument of type 'long unsigned int',
        but argument 4 has type 'bfd_size_type' {aka 'long long unsigned int'}
[-Werror=format=]
      576 |       sim_do_commandf (sd, "memory region 0x%" BFD_VMA_FMT
"x,0x%lx",
          |                            ^~~~~~~~~~~~~~~~~~~
      577 |          interp_load_addr, interpsiz);
          |                            ~~~~~~~~~
          |                            |
          |                            bfd_size_type {aka long long unsigned
int}

Proposed possible change as:
https://sourceware.org/pipermail/gdb-patches/2022-May/189288.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug sim/29184] [PATCH] sim fails to build on 32-bit systems with -Werror=format-security

[slyich at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29184

--- Comment #1 from Sergei Trofimovich <slyich at gmail dot com> ---
Created attachment 14114
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14114&action=edit
0001-sim-fix-BFD_VMA-format-arguments-on-32-bit-hosts.patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug sim/29184] [PATCH] sim fails to build on 32-bit systems with -Werror=format-security

[vapier at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29184

--- Comment #2 from Mike Frysinger <vapier at gentoo dot org> ---
please post patches to the gdb-patches@ mailing list

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug sim/29184] [PATCH] sim fails to build on 32-bit systems with -Werror=format-security

[slyich at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29184

--- Comment #3 from Sergei Trofimovich <slyich at gmail dot com> ---
It was posted to gdb-patches on May 21 as
https://sourceware.org/pipermail/gdb-patches/2022-May/189288.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug sim/29184] [PATCH] sim fails to build on 32-bit systems with -Werror=format-security

[slyich at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29184

Sergei Trofimovich <slyich at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Sergei Trofimovich <slyich at gmail dot com> ---
Pushed to master as
https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=33b90f59f3465041a620ad4f6504a35b578cfc65

-- 
You are receiving this mail because:
You are on the CC list for the bug.