[Bug gdb/29195] New: [gdb, gcc-12/m32] FAIL: gdb.mi/mi-var-block.exp: update all vars: cb foo changed (unexpected output)

[Bug gdb/29195] New: [gdb, gcc-12/m32] FAIL: gdb.mi/mi-var-block.exp: update all vars: cb foo changed (unexpected output)

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29195

            Bug ID: 29195
           Summary: [gdb, gcc-12/m32] FAIL: gdb.mi/mi-var-block.exp:
                    update all vars: cb foo changed (unexpected output)
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: gdb
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

On openSUSE Tumbleweed, with gcc 12.1.0, with test-case gdb.mi/mi-var-block.exp
and target board unix/-m32, I run into:
...
PASS: gdb.mi/mi-var-block.exp: step at do_block_test 2
Expecting: ^(-var-update \*[^M
]+)?(\^done,changelist=\[{name="foo",in_scope="true",type_changed="false",has_more="0"},\
{name="cb",in_scope="true",type_changed="false",has_more="0"}\][^M
]+[(]gdb[)] ^M
[ ]*)
-var-update *^M
^done,changelist=[{name="foo",in_scope="true",type_changed="false",has_more="0"}]^M
(gdb) ^M
FAIL: gdb.mi/mi-var-block.exp: update all vars: cb foo changed (unexpected
output)
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/29195] [gdb, gcc-12/m32] FAIL: gdb.mi/mi-var-block.exp: update all vars: cb foo changed (unexpected output)

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29195

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
The explanation is that the source contains:
...
  int cb = 12;
...
and the test-case tries to detect whether cb has changed by the assignment.

However, if the stack location accidentally was 12 already, then no change is
detected.

Fixed by making sure the change is detected relative to a known value:
...
diff --git a/gdb/testsuite/gdb.mi/mi-var-block.exp
b/gdb/testsuite/gdb.mi/mi-var-block
.exp
index 2f8d39a6acd..a1ef2d1ad52 100644
--- a/gdb/testsuite/gdb.mi/mi-var-block.exp
+++ b/gdb/testsuite/gdb.mi/mi-var-block.exp
@@ -40,6 +40,11 @@ mi_gdb_load ${binfile}

 mi_runto do_block_tests

+# step to "cb = 12;"
+mi_step_to "do_block_tests" "" "var-cmd.c" \
+    [gdb_get_line_number "cb = 12;"] \
+    "step at do_block_test 0"
+
 # Test: c_variable-3.2
 # Desc: create cb and foo
 mi_create_varobj "cb" "cb" "create local variable cb"
diff --git a/gdb/testsuite/gdb.mi/var-cmd.c b/gdb/testsuite/gdb.mi/var-cmd.c
index fddb0d39a5e..f3312788a80 100644
--- a/gdb/testsuite/gdb.mi/var-cmd.c
+++ b/gdb/testsuite/gdb.mi/var-cmd.c
@@ -207,7 +207,8 @@ subroutine1 (int i, long *l)
 void
 do_block_tests ()
 {
-  int cb = 12;
+  int cb = 0;
+  cb = 12;

   {
     int foo;
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/29195] [gdb, gcc-12/m32] FAIL: gdb.mi/mi-var-block.exp: update all vars: cb foo changed (unexpected output)

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29195

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|gdb                         |testsuite

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/29195] [gdb, gcc-12/m32] FAIL: gdb.mi/mi-var-block.exp: update all vars: cb foo changed (unexpected output)

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29195

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
https://sourceware.org/pipermail/gdb-patches/2022-May/189643.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/29195] [gdb, gcc-12/m32] FAIL: gdb.mi/mi-var-block.exp: update all vars: cb foo changed (unexpected output)

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29195

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.1

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=bb785a92a88b538831d72e36f2d0fce76e0a32b1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/29195] [gdb, gcc-12/m32] FAIL: gdb.mi/mi-var-block.exp: update all vars: cb foo changed (unexpected output)

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29195

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
Fixed by committed mentioned in previous comment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.