[Bug gdb/29316] New: gdb-add-index always generates an error when libdebuginfod wasn't compiled in

[Bug gdb/29316] New: gdb-add-index always generates an error when libdebuginfod wasn't compiled in

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29316

            Bug ID: 29316
           Summary: gdb-add-index always generates an error when
                    libdebuginfod wasn't compiled in
           Product: gdb
           Version: 12.1
            Status: NEW
          Severity: normal
          Priority: P2
         Component: gdb
          Assignee: unassigned at sourceware dot org
          Reporter: mark at klomp dot org
  Target Milestone: ---

gdb-add-index contains:

$GDB --batch -nx -iex 'set auto-load no' \
    -iex 'set debuginfod enabled off' \
    -ex "file $file" -ex "save gdb-index $dwarf5 $dir"

So it always disables debuginfod.
But gdb/debuginfod-support.c has:

/* Set callback for "set debuginfod enabled".  */ 

static void 
set_debuginfod_enabled (const char *value) 
{ 
#if defined(HAVE_LIBDEBUGINFOD) 
  debuginfod_enabled = value; 
#else 
  error (NO_IMPL); 
#endif 
}

So when not compiled against libdebuginfod that will always generate a error on
stderr.

This causes some testcase in dwz to FAIL, because any output to stderr is seen
as failure.

It also makes package build logs (if they use gdb-add-index) somewhat noisy.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/29316] gdb-add-index always generates an error when libdebuginfod wasn't compiled in

[amerey at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29316

Aaron Merey <amerey at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amerey at redhat dot com
           Assignee|unassigned at sourceware dot org   |amerey at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/29316] gdb-add-index always generates an error when libdebuginfod wasn't compiled in

[amerey at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29316

Aaron Merey <amerey at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from Aaron Merey <amerey at redhat dot com> ---
Patch posted to mailing list

https://sourceware.org/pipermail/gdb-patches/2022-July/190521.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/29316] gdb-add-index always generates an error when libdebuginfod wasn't compiled in

[amerey at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29316

Aaron Merey <amerey at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #2 from Aaron Merey <amerey at redhat dot com> ---
Fixed in commit 92b0a182fe00

-- 
You are receiving this mail because:
You are on the CC list for the bug.