[Bug symtab/29336] New: [gdb, debug-types, debug-names] Bad CU index complaint not triggered

[Bug symtab/29336] New: [gdb, debug-types, debug-names] Bad CU index complaint not triggered

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29336

            Bug ID: 29336
           Summary: [gdb, debug-types, debug-names] Bad CU index complaint
                    not triggered
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: symtab
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

While working on PR29334, I noticed this code right above the DW_IDX_type_unit
handling code:
...
        case DW_IDX_compile_unit:
          /* Don't crash on bad data.  */
          if (ull >= per_bfd->all_comp_units.size ())
            {
              complaint (_(".debug_names entry has bad CU index %s"
                           " [in module %s]"),
                         pulongest (ull),
                         objfile_name (objfile));
              continue;
            }
          per_cu = per_bfd->get_cu (ull);
          break;
...

So, if I have 5 CUs and 5 TUs, and a ull CU index of 7, we should complain.

But we don't because we compare with "per_bfd->all_comp_units.size ()" instead
of with "per_bfd->all_comp_units.size () - per_bfd->tu_stats.nr_tus".

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/29336] [gdb, debug-types, debug-names] Bad CU index complaint not triggered

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29336

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
Hmm, there are similar complaints for gdb-index, perhaps the same problem in
dw2_symtab_iter_next?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/29336] [gdb, debug-types, debug-names] Bad CU index complaint not triggered

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29336

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
Created attachment 14210
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14210&action=edit
tentative patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/29336] [gdb, debug-types, debug-names] Bad CU index complaint not triggered

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29336

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/29336] [gdb, debug-types, debug-names] Bad CU index complaint not triggered

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29336

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #1)
> Hmm, there are similar complaints for gdb-index, perhaps the same problem in
> dw2_symtab_iter_next?

Filed as PR29367.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/29336] [gdb, debug-types, debug-names] Bad CU index complaint not triggered

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29336

--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
Submitted patch:
https://sourceware.org/pipermail/gdb-patches/2022-July/190750.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/29336] [gdb, debug-types, debug-names] Bad CU index complaint not triggered

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29336

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |13.1
         Resolution|---                         |FIXED

--- Comment #5 from Tom de Vries <vries at gcc dot gnu.org> ---
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=2fe9a3c41faa71b1f2bde40e818187491a5a9925

-- 
You are receiving this mail because:
You are on the CC list for the bug.