[Bug symtab/29343] [gdb/symtab] per_cu->length set without initial_length_size

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29343

--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #2)
> ...
> @@ -23377,8 +23377,6 @@ dwarf2_per_cu_data::get_header () const
>        const gdb_byte *info_ptr
>         = this->section->buffer + to_underlying (this->sect_off);
>  
> -      memset (&m_header, 0, sizeof (m_header));
> -
>        read_comp_unit_head (&m_header, info_ptr, this->section,
>                            rcuh_kind::COMPILE);
>  
> ...

Hmm, so struct comp_unit_head is a POD, that we init using memset, sometimes.

Sometimes we just initialize a bit, like this:
...
      /* Initialize it due to a false compiler warning.  */
      header.signature = -1;
      header.type_cu_offset_in_tu = (cu_offset) -1;
...

And sometime not at all (before the reading is done).

To make sure things are initialized consistently, we'd have to start using
constructors, which I suppose means we no longer can use the memset.

So I guess this requires a larger rewrite.

-- 
You are receiving this mail because:
You are on the CC list for the bug.