[Bug symtab/29343] New: [gdb/symtab] per_cu->length set without initial_length_size

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29343

            Bug ID: 29343
           Summary: [gdb/symtab] per_cu->length set without
                    initial_length_size
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: symtab
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

I ran into a race condition for per_cu->length, and while investigating this I
noticed this particular requirement about length:
...
  /* The start offset and length of this compilation unit.                      
     NOTE: Unlike comp_unit_head.length, this length includes                   
     initial_length_size.                                                       
     If the DIE refers to a DWO file, this is always of the original die,       
     not the DWO file.  */
  sect_offset sect_off {};
  unsigned int length = 0;
...

Grepping through the sources shows 3 spots were this requirement is not met:
...
$ grep "cu->length = " gdb/dwarf2/read.c
  the_cu->length = length;
          this_cu->length = cu->header.get_length ();
            this_cu->length = cu->header.get_length ();
  this_cu->length = m_new_cu->header.get_length ();
      this_cu->length = cu_header.length + cu_header.initial_length_size;
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.