[Bug cli/29582] Usability improvement: CTRL+C when debugindod client is downloading a file

["amerey at redhat dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29582

--- Comment #8 from Aaron Merey <amerey at redhat dot com> ---
(In reply to Tom de Vries from comment #7)
> Created attachment 14367 [details]
> tentative patch

Thanks for the patch, I think this works nicely. I just have a couple
suggestions regarding some of the wording. 

> +      if (debuginfod_cancel == debuginfod_ask)
> +	{
> +	  int resp = nquery (_("Cancel further downloading for this session? "));
> +	  if (resp)
> +	    debuginfod_cancel = debuginfod_all;
> +	  else
> +	    debuginfod_cancel = debuginfod_one;
> +	}
> +      if (debuginfod_cancel == debuginfod_all)
> +	{
> +	  gdb_printf (_("Debuginfod has been disabled.\n"));

Here it could be useful to include instructions for how to re-enable
debuginfod. Something like: 
"Debuginfod has been disabled. To re-enable use the 'set debuginfod enabled on'
command."

> +  add_setshow_enum_cmd ("cancel", class_run, debuginfod_cancel_enum,
> +			_("Set cancellation mode for debuginfod."),
> +			_("Show cancellation mode for debuginfod."),
> +			_("\
> +When set to one, ^C cancels a single download.\n\
> +When set to all, ^C cancels all further downloads.\n\
> +When set to ask, ^C asks what to do."),

To be extra clear about what the cancellation mode is I'd add the following
line:

The cancellation mode controls the behavior of ^C while a file is downloading
from debuginfod.\n\
When set to one, ^C cancels a single download.\n\
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.