[Bug sim/29595] New: RISC-V simulator cannot run multiply instructions

[Bug sim/29595] New: RISC-V simulator cannot run multiply instructions

[research_trasio at irq dot a4lg.com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29595

            Bug ID: 29595
           Summary: RISC-V simulator cannot run multiply instructions
           Product: gdb
           Version: HEAD
            Status: UNCONFIRMED
          Severity: critical
          Priority: P2
         Component: sim
          Assignee: unassigned at sourceware dot org
          Reporter: research_trasio at irq dot a4lg.com
                CC: vapier at gentoo dot org
  Target Milestone: ---

Created attachment 14343
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14343&action=edit
Reproduction source code + generated object files + simulator logs

[POSSIBLE RELEASE BLOCKER FOR GDB 13.1]

On the latest master, RISC-V simulator cannot run multiply instructions (but
CAN run division instructions).

I completely know the cause:
On the Binutils side, new multiply-only instruction subset extension 'Zmmul' is
being added.  I sent a patchset which spans *both Binutils and GDB* but *only
Binutils part is committed.*

This is the one (same but both to binutils and gdb-patches ML):
<https://sourceware.org/pipermail/binutils/2022-August/122653.html>
<https://sourceware.org/pipermail/gdb-patches/2022-August/191295.html>

I'm proposing remaining part (GDB / simulator part) as a separate patchset but
there's no response from the GDB side...
<https://sourceware.org/pipermail/gdb-patches/2022-August/191609.html>
<https://sourceware.org/pipermail/gdb-patches/2022-September/191841.html> (ping
1)
<https://sourceware.org/pipermail/gdb-patches/2022-September/191995.html> (ping
2)

Not being able to run the multiply instructions on the simulator is clearly a
release blocker for GDB 13.1.  So I'm reporting this to track this issue.

My copyright assignment to both Binutils and GDB is complete and I'm now even a
"write after approval" committer.  If a maintainer gives me an approval, I can
commit it in a day.


GitHub tracker of me:
<https://github.com/a4lg/binutils-gdb/wiki/sim_riscv_zmmul>
<https://github.com/a4lg/binutils-gdb/wiki/riscv_zmmul>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug sim/29595] RISC-V simulator cannot run multiply instructions

[research_trasio at irq dot a4lg.com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29595

Tsukasa OI <research_trasio at irq dot a4lg.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |riscv64-*

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug sim/29595] RISC-V simulator cannot run multiply instructions (but can division instructions)

[research_trasio at irq dot a4lg.com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29595

Tsukasa OI <research_trasio at irq dot a4lg.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|RISC-V simulator cannot run |RISC-V simulator cannot run
                   |multiply instructions       |multiply instructions (but
                   |                            |can division instructions)

--- Comment #1 from Tsukasa OI <research_trasio at irq dot a4lg.com> ---
As far I know, Nelson approved the Binutils part (and committed the original
patchset) but he said he cannot approve the GDB part (since he's not a
maintainer).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug sim/29595] RISC-V simulator cannot run multiply instructions (but can run division instructions)

[research_trasio at irq dot a4lg.com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29595

Tsukasa OI <research_trasio at irq dot a4lg.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|RISC-V simulator cannot run |RISC-V simulator cannot run
                   |multiply instructions (but  |multiply instructions (but
                   |can division instructions)  |can run division
                   |                            |instructions)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug sim/29595] RISC-V simulator cannot run multiply instructions (but can run division instructions)

[research_trasio at irq dot a4lg.com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29595

Tsukasa OI <research_trasio at irq dot a4lg.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |research_trasio at irq dot a4lg.co
                   |                            |m

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug sim/29595] RISC-V simulator cannot run multiply instructions (but can run division instructions)

[research_trasio at irq dot a4lg.com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29595

Tsukasa OI <research_trasio at irq dot a4lg.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P2                          |P1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug sim/29595] RISC-V simulator cannot run multiply instructions (but can run division instructions)

[aburgess at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29595

Andrew Burgess <aburgess at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |aburgess at redhat dot com
         Resolution|---                         |FIXED

--- Comment #2 from Andrew Burgess <aburgess at redhat dot com> ---
I pushed the patch from Tsukasa OI for this issue, but forgot to add the bug
link into the commit message.  Ooops.

This is the commit on upstream master branch:

  commit c6422d7be70f14bf7140085f2fc7a592737f5df5
  Author: Tsukasa OI <research_trasio@irq.a4lg.com>
  Date:   Wed Aug 31 01:46:08 2022 +0000

      sim/riscv: fix multiply instructions on simulator

This issue should now be resolved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.