* [Bug server/29652] [gdbserver] Keeping symbols between two gdbserver sessions breaks second session
2022-10-05 9:19 [Bug server/29652] New: [gdbserver] Keeping symbols between two gdbserver sessions breaks second session vries at gcc dot gnu.org
@ 2022-10-05 9:25 ` vries at gcc dot gnu.org
2022-10-05 9:51 ` vries at gcc dot gnu.org
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: vries at gcc dot gnu.org @ 2022-10-05 9:25 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=29652
--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
Playing around a bit more with the example, using "symbol-file" instead of
"file" doesn't fix the problem but using "exec-file" does.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug server/29652] [gdbserver] Keeping symbols between two gdbserver sessions breaks second session
2022-10-05 9:19 [Bug server/29652] New: [gdbserver] Keeping symbols between two gdbserver sessions breaks second session vries at gcc dot gnu.org
2022-10-05 9:25 ` [Bug server/29652] " vries at gcc dot gnu.org
@ 2022-10-05 9:51 ` vries at gcc dot gnu.org
2022-10-05 10:04 ` vries at gcc dot gnu.org
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: vries at gcc dot gnu.org @ 2022-10-05 9:51 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=29652
--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
This fixes it:
...
diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c
index a6a9ec5c86b..ce3278f5e89 100644
--- a/gdb/solib-svr4.c
+++ b/gdb/solib-svr4.c
@@ -571,9 +571,11 @@ find_program_interpreter (void)
int sect_size = bfd_section_size (interp_sect);
gdb::byte_vector buf (sect_size);
- bfd_get_section_contents (current_program_space->exec_bfd (),
- interp_sect, buf.data (), 0, sect_size);
- return buf;
+ bool res
+ = bfd_get_section_contents (current_program_space->exec_bfd (),
+ interp_sect, buf.data (), 0, sect_size);
+ if (res)
+ return buf;
}
}
...
It makes the function fall back to:
...
/* If we didn't find it, use the target auxiliary vector. */
return read_program_header (PT_INTERP, NULL, NULL);
...
which works for this case.
But perhaps the root cause of the problem is that bfd_get_section_contents
returns false in the first place, and we need "gdb_assert (res)" instead, and
fix the assert?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug server/29652] [gdbserver] Keeping symbols between two gdbserver sessions breaks second session
2022-10-05 9:19 [Bug server/29652] New: [gdbserver] Keeping symbols between two gdbserver sessions breaks second session vries at gcc dot gnu.org
2022-10-05 9:25 ` [Bug server/29652] " vries at gcc dot gnu.org
2022-10-05 9:51 ` vries at gcc dot gnu.org
@ 2022-10-05 10:04 ` vries at gcc dot gnu.org
2022-10-05 10:40 ` vries at gcc dot gnu.org
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: vries at gcc dot gnu.org @ 2022-10-05 10:04 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=29652
--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #2)
> But perhaps the root cause of the problem is that bfd_get_section_contents
> returns false in the first place,
Drilling down, this happens here in target_fileio_pread:
...
else if (fh->target == NULL)
*target_errno = FILEIO_EIO;
...
because:
...
(gdb) p *fh
$8 = {target = 0x0, target_fd = 4}
...
In contrast, the first time, when the read succeeds, we have instead:
...
(gdb) p *fh
$15 = {target = 0x16d43a0, target_fd = 4}
...
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug server/29652] [gdbserver] Keeping symbols between two gdbserver sessions breaks second session
2022-10-05 9:19 [Bug server/29652] New: [gdbserver] Keeping symbols between two gdbserver sessions breaks second session vries at gcc dot gnu.org
` (2 preceding siblings ...)
2022-10-05 10:04 ` vries at gcc dot gnu.org
@ 2022-10-05 10:40 ` vries at gcc dot gnu.org
2022-10-05 10:43 ` vries at gcc dot gnu.org
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: vries at gcc dot gnu.org @ 2022-10-05 10:40 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=29652
--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
Triggered "gdb_assert (res)" using this as well:
...
$ gdb -q -batch \
-ex "shell gdbserver 127.0.0.1:2345 ~/a.out &" \
-ex "target remote 127.0.0.1:2345" \
-ex continue \
-ex "shell gdbserver 127.0.0.1:2345 ~/a.out &" \
-ex "target remote 127.0.0.1:2345" \
-ex continue
...
so it's not specific to using gdbserver stdin/stdout.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug server/29652] [gdbserver] Keeping symbols between two gdbserver sessions breaks second session
2022-10-05 9:19 [Bug server/29652] New: [gdbserver] Keeping symbols between two gdbserver sessions breaks second session vries at gcc dot gnu.org
` (3 preceding siblings ...)
2022-10-05 10:40 ` vries at gcc dot gnu.org
@ 2022-10-05 10:43 ` vries at gcc dot gnu.org
2022-10-05 12:54 ` vries at gcc dot gnu.org
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: vries at gcc dot gnu.org @ 2022-10-05 10:43 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=29652
--- Comment #5 from Tom de Vries <vries at gcc dot gnu.org> ---
Could be a duplicate of PR22417.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug server/29652] [gdbserver] Keeping symbols between two gdbserver sessions breaks second session
2022-10-05 9:19 [Bug server/29652] New: [gdbserver] Keeping symbols between two gdbserver sessions breaks second session vries at gcc dot gnu.org
` (4 preceding siblings ...)
2022-10-05 10:43 ` vries at gcc dot gnu.org
@ 2022-10-05 12:54 ` vries at gcc dot gnu.org
2022-10-05 12:54 ` vries at gcc dot gnu.org
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: vries at gcc dot gnu.org @ 2022-10-05 12:54 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=29652
--- Comment #6 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #5)
> Could be a duplicate of PR22417.
Confirmed, running into the same tsan error.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug server/29652] [gdbserver] Keeping symbols between two gdbserver sessions breaks second session
2022-10-05 9:19 [Bug server/29652] New: [gdbserver] Keeping symbols between two gdbserver sessions breaks second session vries at gcc dot gnu.org
` (5 preceding siblings ...)
2022-10-05 12:54 ` vries at gcc dot gnu.org
@ 2022-10-05 12:54 ` vries at gcc dot gnu.org
2022-10-05 12:58 ` vries at gcc dot gnu.org
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: vries at gcc dot gnu.org @ 2022-10-05 12:54 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=29652
--- Comment #7 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #6)
> Confirmed, running into the same tsan error.
I meant asan.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug server/29652] [gdbserver] Keeping symbols between two gdbserver sessions breaks second session
2022-10-05 9:19 [Bug server/29652] New: [gdbserver] Keeping symbols between two gdbserver sessions breaks second session vries at gcc dot gnu.org
` (6 preceding siblings ...)
2022-10-05 12:54 ` vries at gcc dot gnu.org
@ 2022-10-05 12:58 ` vries at gcc dot gnu.org
2022-10-05 15:43 ` vries at gcc dot gnu.org
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: vries at gcc dot gnu.org @ 2022-10-05 12:58 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=29652
--- Comment #8 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #3)
> Drilling down, this happens here in target_fileio_pread:
> ...
> else if (fh->target == NULL)
> *target_errno = FILEIO_EIO;
> ...
> because:
> ...
> (gdb) p *fh
> $8 = {target = 0x0, target_fd = 4}
> ...
The target = NULL is done by fileio_handles_invalidate_target, which is called
from target_close.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug server/29652] [gdbserver] Keeping symbols between two gdbserver sessions breaks second session
2022-10-05 9:19 [Bug server/29652] New: [gdbserver] Keeping symbols between two gdbserver sessions breaks second session vries at gcc dot gnu.org
` (7 preceding siblings ...)
2022-10-05 12:58 ` vries at gcc dot gnu.org
@ 2022-10-05 15:43 ` vries at gcc dot gnu.org
2022-10-12 15:42 ` vries at gcc dot gnu.org
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: vries at gcc dot gnu.org @ 2022-10-05 15:43 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=29652
--- Comment #9 from Tom de Vries <vries at gcc dot gnu.org> ---
Well, this is a different way of dealing with it:
...
diff --git a/gdb/remote.c b/gdb/remote.c
index 2f6cb2d01ee..3ae6ad688b8 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -2543,14 +2543,13 @@ remote_target::remote_add_inferior (bool fake_pid_p,
int pid,
int attached,
inf->attach_flag = attached;
inf->fake_pid_p = fake_pid_p;
+ current_program_space->exec_close ();
+
/* If no main executable is currently open then attempt to
open the file that was executed to create this inferior. */
- if (try_open_exec && get_exec_file (0) == NULL)
+ if (try_open_exec)
exec_file_locate_attach (pid, 0, 1);
- /* Check for exec file mismatch, and let the user solve it. */
- validate_exec_file (1);
-
return inf;
}
...
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug server/29652] [gdbserver] Keeping symbols between two gdbserver sessions breaks second session
2022-10-05 9:19 [Bug server/29652] New: [gdbserver] Keeping symbols between two gdbserver sessions breaks second session vries at gcc dot gnu.org
` (8 preceding siblings ...)
2022-10-05 15:43 ` vries at gcc dot gnu.org
@ 2022-10-12 15:42 ` vries at gcc dot gnu.org
2022-10-20 8:42 ` vries at gcc dot gnu.org
2022-10-20 8:44 ` vries at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: vries at gcc dot gnu.org @ 2022-10-12 15:42 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=29652
--- Comment #10 from Tom de Vries <vries at gcc dot gnu.org> ---
https://sourceware.org/pipermail/gdb-patches/2022-October/192615.html
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug server/29652] [gdbserver] Keeping symbols between two gdbserver sessions breaks second session
2022-10-05 9:19 [Bug server/29652] New: [gdbserver] Keeping symbols between two gdbserver sessions breaks second session vries at gcc dot gnu.org
` (9 preceding siblings ...)
2022-10-12 15:42 ` vries at gcc dot gnu.org
@ 2022-10-20 8:42 ` vries at gcc dot gnu.org
2022-10-20 8:44 ` vries at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: vries at gcc dot gnu.org @ 2022-10-20 8:42 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=29652
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
Target Milestone|--- |13.1
--- Comment #11 from Tom de Vries <vries at gcc dot gnu.org> ---
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=8e94bb3e3a478544c0d8abfad8404af015f7130b
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug server/29652] [gdbserver] Keeping symbols between two gdbserver sessions breaks second session
2022-10-05 9:19 [Bug server/29652] New: [gdbserver] Keeping symbols between two gdbserver sessions breaks second session vries at gcc dot gnu.org
` (10 preceding siblings ...)
2022-10-20 8:42 ` vries at gcc dot gnu.org
@ 2022-10-20 8:44 ` vries at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: vries at gcc dot gnu.org @ 2022-10-20 8:44 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=29652
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |qiyao at gcc dot gnu.org
--- Comment #12 from Tom de Vries <vries at gcc dot gnu.org> ---
*** Bug 22417 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread