public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org> To: gdb-prs@sourceware.org Subject: [Bug testsuite/29697] [gdb/testsuite, local-remote-host] FAIL: gdb.base/callfuncs.exp: noproto: p ((int (*) ()) t_float_values2)(3.14159,float_val2) Date: Fri, 28 Oct 2022 14:07:16 +0000 [thread overview] Message-ID: <bug-29697-4717-yzLuGcaX1K@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-29697-4717@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=29697 --- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> --- (In reply to Tom de Vries from comment #0) > I managed to make things work by removing ${board}_download from the host > board file, but that fills my home dir with temp files... And that breaks down once (test-case gdb.dwarf2/dwz.exp) you want to compile an exec using -o ~/dwz, and you already have a directory ~/dwz. I tried to get that test-case to work by removing ${board}_download and ${board}_file and using a REMOTE_HOST_DIR, like so: ... if { ![info exists REMOTE_HOST_DIR] } { set REMOTE_HOST_DIR [file join [pwd] "remote-host-dir"] } if { ![file exists $REMOTE_HOST_DIR] } { file mkdir $REMOTE_HOST_DIR } set_board_info remotedir $REMOTE_HOST_DIR ... I got to: ... diff --git a/gdb/testsuite/boards/local-remote-host.exp b/gdb/testsuite/boards/local-remote-host.exp # Like standard_spawn, but force pseudo-tty allocation, with 'ssh -t'. proc ${board}_spawn { board cmd } { - global board_info + global board_info REMOTE_HOST_DIR set remote [board_info $board hostname] set username [board_info $board username] set RSH [board_info $board rsh_prog] - spawn $RSH -t -l $username $remote $cmd + spawn $RSH -t -l $username $remote "cd $REMOTE_HOST_DIR; $cmd" set board_info($board,fileid) $spawn_id return $spawn_id } diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index e2cda30b95a..5f1f2fa0fbf 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -2099,7 +2099,15 @@ proc gdb_file_cmd { arg } { set gdb_file_cmd_debug_info "fail" if [is_remote host] { - set arg [remote_download host $arg] + set pre_arg $arg + set arg [remote_upload host $arg] + if { $arg == "" } { + perror "upload failed: remote_upload host $pre_arg" + return -1 + } + } + if [is_remote target] { + set arg [remote_download target $arg] if { $arg == "" } { perror "download failed" return -1 @@ -6217,6 +6225,9 @@ proc standard_output_file_with_gdb_instance {basename} { # Return the name of a file in our standard temporary directory. proc standard_temp_file {basename} { + if { [is_remote host] } { + return $basename + } # Since a particular runtest invocation is only executing a single test # file at any given time, we can use the runtest pid to build the # path of the temp directory. ... And I'm at the point that AFAICT, the gdb_default_target_compile_1 proc does: ... set compiler_flags $opts if {[is_remote host]} { remote_upload host [file tail $destfile] $destfile remote_file host delete [file tail $destfile] } ... and the remote_upload fails, the exec is deleted and execution fails. I seems that remote_upload indeed does not take remotedir into account. -- You are receiving this mail because: You are on the CC list for the bug.
prev parent reply other threads:[~2022-10-28 14:07 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-17 21:35 [Bug testsuite/29697] New: " vries at gcc dot gnu.org 2022-10-28 14:07 ` vries at gcc dot gnu.org [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-29697-4717-yzLuGcaX1K@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=gdb-prs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).