[Bug testsuite/29697] New: [gdb/testsuite, local-remote-host] FAIL: gdb.base/callfuncs.exp: noproto: p ((int (*) ()) t_float_values2)(3.14159,float_val2)

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29697

            Bug ID: 29697
           Summary: [gdb/testsuite, local-remote-host] FAIL:
                    gdb.base/callfuncs.exp: noproto: p ((int (*) ())
                    t_float_values2)(3.14159,float_val2)
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

With host board local-remote-host.exp and test-case gdb.base/callfuncs.exp, I
run into:
...
(gdb) PASS: gdb.base/callfuncs.exp: noproto: p
t_float_values2(3.14159,float_val2)
p ((int (*) ()) t_float_values2)(3.14159,float_val2)^M
$30 = 0^M
(gdb) FAIL: gdb.base/callfuncs.exp: noproto: p ((int (*) ())
t_float_values2)(3.14159,float_val2)
...

It took me a while to realize that the problem is that there are two
prepare_for_testing calls, writing to the same exec, and somehow the second has
no effect.

In other words, we're seeing the effect of having additional_flags=-DPROTOTYPES
in both cases.

This can easily be solved with something like:
...
diff --git a/gdb/testsuite/gdb.base/callfuncs.exp
b/gdb/testsuite/gdb.base/callfuncs.exp
index 44289eebc8b..403f127bfe8 100644
--- a/gdb/testsuite/gdb.base/callfuncs.exp
+++ b/gdb/testsuite/gdb.base/callfuncs.exp
@@ -540,11 +540,11 @@ proc perform_all_tests {prototypes} {

 # Perform all tests with and without function prototypes.

-if { ![prepare_for_testing "failed to prepare" $testfile $srcfile
"$compile_flags additio
nal_flags=-DPROTOTYPES"] } {
+if { ![prepare_for_testing "failed to prepare" $testfile-proto $srcfile
"$compile_f
lags additional_flags=-DPROTOTYPES"] } {
     perform_all_tests 1
 }

-if { ![prepare_for_testing "failed to prepare" $testfile $srcfile
"$compile_flags additio
nal_flags=-DNO_PROTOTYPES"] } {
+if { ![prepare_for_testing "failed to prepare" $testfile-noproto $srcfile
"$compile
_flags additional_flags=-DNO_PROTOTYPES"] } {
     with_test_prefix "noproto" {
        perform_all_tests 0
     }
...

It's a good idea to commit the patch, for reasons of having less confusion, as
other recent patches have done.

But the FAIL points to a problem with the file upload/download mechanism for
the host board.

I managed to make things work by removing ${board}_download from the host board
file, but that fills my home dir with temp files...

I tried other ways, but am possibly running into dejagnu bugs (using a.out as
hardcoded intermediate file for objects does not look sane to me), so this
looks like non-trivial to fix.

-- 
You are receiving this mail because:
You are on the CC list for the bug.