public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug testsuite/29734] New: [gdb/testsuite, local-remote-host-native] FAIL: gdb.server/stop-reply-no-thread-multi.exp: target-non-stop=off: to_disable=: set remote threads-packet off (timeout)
@ 2022-10-31 8:46 vries at gcc dot gnu.org
2023-03-28 15:48 ` [Bug testsuite/29734] " cvs-commit at gcc dot gnu.org
2023-03-28 15:51 ` vries at gcc dot gnu.org
0 siblings, 2 replies; 3+ messages in thread
From: vries at gcc dot gnu.org @ 2022-10-31 8:46 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=29734
Bug ID: 29734
Summary: [gdb/testsuite, local-remote-host-native] FAIL:
gdb.server/stop-reply-no-thread-multi.exp:
target-non-stop=off: to_disable=: set remote
threads-packet off (timeout)
Product: gdb
Version: HEAD
Status: NEW
Severity: normal
Priority: P2
Component: testsuite
Assignee: unassigned at sourceware dot org
Reporter: vries at gcc dot gnu.org
Target Milestone: ---
I tried out running the gdb.server/*.exp test-cases with host+target board
local-remote-host-native, but in the first test-case run into a time-out:
...
(gdb) PASS: gdb.server/stop-reply-no-thread-multi.exp: target-non-stop=off:
to_disable=: disconnect
builtin_spawn /usr/bin/ssh -t -l vries 127.0.0.1
/home/vries/gdb_versions/devel/build/gdb/testsuite/../../gdbserver/gdbserver
--once localhost:2346
/home/vries/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.server/stop-reply-no-thread-multi/stop-reply-no-thread-multi^M
Process
/home/vries/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.server/stop-reply-no-thread-multi/stop-reply-no-thread-multi
created; pid = 32600^M
Listening on port 2346^M
set remote threads-packet off^M
FAIL: gdb.server/stop-reply-no-thread-multi.exp: target-non-stop=off:
to_disable=: set remote threads-packet off (timeout)
...
AFAICT, this is due to this line in ${board}_spawn:
...
set board_info($board,fileid) $spawn_id
...
We have the following series of events:
- gdb is spawned, setting fileid
- a few gdb commands (set height etc) are send using fileid, and are successful
- gdbserver is spawned, overwriting fileid
- the next gdb command is sent to gdb using fileid, so it's send
to gdbserver instead of gdb, and we run into the timeout.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug testsuite/29734] [gdb/testsuite, local-remote-host-native] FAIL: gdb.server/stop-reply-no-thread-multi.exp: target-non-stop=off: to_disable=: set remote threads-packet off (timeout)
2022-10-31 8:46 [Bug testsuite/29734] New: [gdb/testsuite, local-remote-host-native] FAIL: gdb.server/stop-reply-no-thread-multi.exp: target-non-stop=off: to_disable=: set remote threads-packet off (timeout) vries at gcc dot gnu.org
@ 2023-03-28 15:48 ` cvs-commit at gcc dot gnu.org
2023-03-28 15:51 ` vries at gcc dot gnu.org
1 sibling, 0 replies; 3+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-03-28 15:48 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=29734
--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9121a23fa7294542d022c25eda0fe8b9e92c3b59
commit 9121a23fa7294542d022c25eda0fe8b9e92c3b59
Author: Tom de Vries <tdevries@suse.de>
Date: Tue Mar 28 17:48:34 2023 +0200
[gdb/testsuite] Fix local-remote-host-native.exp for gdb.server tests
When running test-case gdb.server/stop-reply-no-thread-multi.exp with
host+target board local-remote-host-native, I run into a time-out:
...
(gdb) PASS: gdb.server/stop-reply-no-thread-multi.exp: target-non-stop=off:
\
to_disable=: disconnect
builtin_spawn /usr/bin/ssh -t -l vries 127.0.0.1 gdbserver --once \
localhost:2346 stop-reply-no-thread-multi^M
Process stop-reply-no-thread-multi created; pid = 32600^M
Listening on port 2346^M
set remote threads-packet off^M
FAIL: gdb.server/stop-reply-no-thread-multi.exp: target-non-stop=off: \
to_disable=: set remote threads-packet off (timeout)
...
This is due to this line in ${board}_spawn:
...
set board_info($board,fileid) $spawn_id
...
We have the following series of events:
- gdb is spawned, setting fileid
- a few gdb commands (set height etc) are send using fileid, arrive at gdb
and
are successful
- gdbserver is spawned, overwriting fileid
- the next gdb command is sent using fileid, so it's send
to gdbserver instead of gdb, and we run into the timeout.
There is some notion of current gdb, tracked in both gdb_spawn_id and
fileid
of the host board (see switch_gdb_spawn_id). And because the host and
target
board are the same, spawning something on the target overwrites the fileid
on
host, and consequently the current gdb.
Fix this by only setting fileid when spawning gdb.
Tested on x86_64-linux.
Now gdb.server/*.exp passes for host+target board local-remote-host-native,
except for file-transfer.exp.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29734
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug testsuite/29734] [gdb/testsuite, local-remote-host-native] FAIL: gdb.server/stop-reply-no-thread-multi.exp: target-non-stop=off: to_disable=: set remote threads-packet off (timeout)
2022-10-31 8:46 [Bug testsuite/29734] New: [gdb/testsuite, local-remote-host-native] FAIL: gdb.server/stop-reply-no-thread-multi.exp: target-non-stop=off: to_disable=: set remote threads-packet off (timeout) vries at gcc dot gnu.org
2023-03-28 15:48 ` [Bug testsuite/29734] " cvs-commit at gcc dot gnu.org
@ 2023-03-28 15:51 ` vries at gcc dot gnu.org
1 sibling, 0 replies; 3+ messages in thread
From: vries at gcc dot gnu.org @ 2023-03-28 15:51 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=29734
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |14.1
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
Fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-28 15:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-31 8:46 [Bug testsuite/29734] New: [gdb/testsuite, local-remote-host-native] FAIL: gdb.server/stop-reply-no-thread-multi.exp: target-non-stop=off: to_disable=: set remote threads-packet off (timeout) vries at gcc dot gnu.org
2023-03-28 15:48 ` [Bug testsuite/29734] " cvs-commit at gcc dot gnu.org
2023-03-28 15:51 ` vries at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).