[Bug testsuite/29778] New: [gdb/testsuite] Revise untested usage

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29778

            Bug ID: 29778
           Summary: [gdb/testsuite] Revise untested usage
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: testsuite
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

The definitions/explanations for UNTESTED in the dejagnu manual are:
...
A test case is not yet complete, and in particular cannot yet produce a PASS or
FAIL. You can also use this outcome in dummy “tests” that note explicitly the
absence of a real test case for a particular property.
...
and:
...
untested
prints a message for an test case that isn’t run for some technical reason. 
...
and:
...
untested
prints a message for an test case that isn’t run for some reason.
...
and:
...
UNTESTED
A test was not run. This is a placeholder used when there is no real test case
yet.
...
and:
...
For example, you might use this in a dummy test whose only role is to record
that a test does not yet exist for some feature.
...

I don't think the definition is very clear, but as I understand it the valid
uses of UNTESTED are:
...
gdb.base/features.exp: PASS: feature a
gdb.base/features.exp: UNTESTED: feature b
...
or:
...
gdb.base/feature-b: UNTESTED: <feature b in more detail>
...

In the gdb testsuite there's an interpretation of UNTESTED as "not having
progressed sufficiently in executing an otherwise complete test-case to
generate a PASS or FAIL", which explains why it's used for say failure to
compile.

I suspect this usage is wrong, but again given the vague definition I'm not
sure.

Anyway, perhaps given the vague definition, I think we should eliminate the
usage of untested, by redefining it to:
...
proc untested { message } {
  error "untested: $message"
}
...
and fixing the errors.

Note that out of a total of:
...
$ egrep -c UNTESTED: gdb.sum 
35
...
I have:
...
$ egrep -c UNTESTED:.*(not supported|unsupported) gdb.sum 
18
...
which probably should use unsupported instead of untested.

-- 
You are receiving this mail because:
You are on the CC list for the bug.