[Bug testsuite/29778] [gdb/testsuite] Revise untested usage

["tromey at sourceware dot org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29778

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

--- Comment #8 from Tom Tromey <tromey at sourceware dot org> ---
I wasn't aware of this bug when I wrote the "require" series.

I also stumbled over the weird text in dejagnu that made me
that "untested" was essentially useless.  So, I changed require
to use unsupported.

On reflection though, I think what dejagnu says isn't super important.
We can just pick the one we like for gdb.

I tend to think the noise is fine.  My reasoning is that these
procs give us a way to see not just that a test didn't run, but
also why it didn't run.  Occasionally this reason could be surprising
and lead to some kind of bug fix.  So my view is that the silent
"return"s in the test cases should be converted.

Centralizing these decisions with "require" or other "do task and
return on failure" procs makes this simpler to achieve.
(Here I was thinking of prepare_for_testing but it looks like
build_executable can call untested.)

One other way centralizing is nice is that if we decide to remove
the noise, we can just remove these calls and be done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.