[Bug tdep/29868] [gdb/tdep, s390x] breakpoint.c:5784: internal-error: bpstat_stop_status_nowatch: Assertion `!target_stopped_by_watchpoint ()'

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29868

--- Comment #7 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Ulrich Weigand from comment #6)
> Thanks for the investigation!
> 

Np :)

> The GDB code to "Do not report this watchpoint again" was added back in 2007
> as part of this patch series:
> https://sourceware.org/pipermail/gdb-patches/2007-September/052502.html
> https://sourceware.org/pipermail/gdb-patches/2007-September/052503.html
> and back then, it probably worked as expected.
> 
> The kernel ptrace implementation was changed to prohibit modifying those
> bits only in 2011 as part of some generic cleanup and tightening of access
> rules.  At that point, we probably missed that it broke GDB.
> 

Ack.

> I agree that the TRAP_HWBKPT check looks correct - several other platforms
> have an equivalent check, so I think the patch is fine.  (Longer term, I'm
> wondering if this check shouldn't move to Linux generic code then?)
> 
> However, I think we should then *also* remove the "Do not report this
> watchpoint again" ptrace call - no sense in having this in if it doesn't
> work anyway; it just wastes time and confuses anyone reading that code.

I've submitted a patch implementing that approach at
https://sourceware.org/pipermail/gdb-patches/2022-December/194635.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.