public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/29942] Read some DWARF purely in background
Date: Tue, 09 Jan 2024 01:46:54 +0000	[thread overview]
Message-ID: <bug-29942-4717-el6rnwYDoB@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29942-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29942

--- Comment #9 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=33c6eaaefcedd45e86d564d014f14cce2620f933

commit 33c6eaaefcedd45e86d564d014f14cce2620f933
Author: Tom Tromey <tom@tromey.com>
Date:   Fri Mar 24 23:35:02 2023 -0600

    Do more DWARF reading in the background

    This patch rearranges the DWARF reader so that more work is done in
    the background.  This is PR symtab/29942.

    The idea here is that there is only a small amount of work that must
    be done on the main thread when scanning DWARF -- before the main
    scan, the only part is mapping the section data.

    Currently, the DWARF reader uses the quick_symbol_functions "lazy"
    functionality to defer even starting to read.  This patch instead
    changes the reader to start reading immediately, but doing more in
    worker tasks.

    Before this patch, "file" on my machine:

        (gdb) file /tmp/gdb
        2023-10-23 12:29:56.885 - command started
        Reading symbols from /tmp/gdb...
        2023-10-23 12:29:58.047 - command finished
        Command execution time: 5.867228 (cpu), 1.162444 (wall)

    After the patch, more work is done in the background and so this takes
    a bit less time:

        (gdb) file /tmp/gdb
        2023-10-23 13:25:51.391 - command started
        Reading symbols from /tmp/gdb...
        2023-10-23 13:25:51.712 - command finished
        Command execution time: 1.894500 (cpu), 0.320306 (wall)

    I think this could be further sped up by using the shared library load
    map to avoid objfile loops like the one in expand_symtab_containing_pc
    -- it seems like the correct objfile could be chosen more directly.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29942
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30174

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2024-01-09  1:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-25 21:21 [Bug symtab/29942] New: " tromey at sourceware dot org
2022-12-25 21:21 ` [Bug symtab/29942] " tromey at sourceware dot org
2022-12-25 21:22 ` tromey at sourceware dot org
2022-12-26  5:53 ` tromey at sourceware dot org
2022-12-27 16:30 ` tromey at sourceware dot org
2023-08-13 15:37 ` tromey at sourceware dot org
2023-08-18 17:49 ` tromey at sourceware dot org
2023-08-19  7:11 ` sam at gentoo dot org
2023-08-23 20:02 ` tromey at sourceware dot org
2023-10-04 12:47 ` tromey at sourceware dot org
2023-11-12 23:27 ` tromey at sourceware dot org
2024-01-09  1:46 ` cvs-commit at gcc dot gnu.org [this message]
2024-01-09  1:48 ` tromey at sourceware dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29942-4717-el6rnwYDoB@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).