public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "tromey at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/29942] Read some DWARF purely in background
Date: Wed, 23 Aug 2023 20:02:17 +0000	[thread overview]
Message-ID: <bug-29942-4717-uA3CqUVi16@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29942-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29942

--- Comment #6 from Tom Tromey <tromey at sourceware dot org> ---
(In reply to Tom Tromey from comment #5)
> I also looked at wrapping the cache iovec in a locked variant.
> However, this code in bfd_cache_close prevents that approach:
> 
>   /* Don't remove this test.  bfd_reinit depends on it.  */
>   if (abfd->iovec != &cache_iovec)
>     return true;
> 
> I think I'll just end up wrapping all "suspect" BFD calls in
> a global lock.  This may not be too bad, especially if we switch
> back to eager mapping of DWARF sections.

There are 135 separate bfd_* functions called by gdb.
So, auditing this is a pain and probably error-prone.
And then some subset have to be wrapped in a lock, including
any that set the BFD error.
Coming back around to maybe trying to make the BFD error be thread-local.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2023-08-23 20:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-25 21:21 [Bug symtab/29942] New: " tromey at sourceware dot org
2022-12-25 21:21 ` [Bug symtab/29942] " tromey at sourceware dot org
2022-12-25 21:22 ` tromey at sourceware dot org
2022-12-26  5:53 ` tromey at sourceware dot org
2022-12-27 16:30 ` tromey at sourceware dot org
2023-08-13 15:37 ` tromey at sourceware dot org
2023-08-18 17:49 ` tromey at sourceware dot org
2023-08-19  7:11 ` sam at gentoo dot org
2023-08-23 20:02 ` tromey at sourceware dot org [this message]
2023-10-04 12:47 ` tromey at sourceware dot org
2023-11-12 23:27 ` tromey at sourceware dot org
2024-01-09  1:46 ` cvs-commit at gcc dot gnu.org
2024-01-09  1:48 ` tromey at sourceware dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29942-4717-uA3CqUVi16@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).