public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "tromey at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug python/30044] Flawed logic when releasing values from all_values buffer
Date: Mon, 30 Jan 2023 22:16:25 +0000	[thread overview]
Message-ID: <bug-30044-4717-nnSN7XZaPy@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30044-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=30044

--- Comment #6 from Tom Tromey <tromey at sourceware dot org> ---
I apparently knew about this problem in the relatively recent past:

commit 42331a1ea2a13ce15ec202c5f0fbef3e5171253c
Author: Tom Tromey <tom@tromey.com>
Date:   Fri Mar 13 17:39:52 2020 -0600

    Change extension language pretty-printers to use value API

    This changes the extension language pretty-printers to use the value
    API.

    Note that new functions were needed, for both Guile and Python.
    Currently both languages always wrap values by removing the values
    from the value chain.  This makes sense to avoid strange behavior with
    watchpoints, and to avoid excessive memory use.  However, when
    printing, it's important to leave the passed-in value untouched, in
    case pretty-printing does nothing -- that way the caller can still
    access it.


This was part of the val_print removal series.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2023-01-30 22:16 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-24 18:59 [Bug python/30044] New: " ssbssa at sourceware dot org
2023-01-24 19:00 ` [Bug python/30044] " ssbssa at sourceware dot org
2023-01-24 19:01 ` ssbssa at sourceware dot org
2023-01-24 19:01 ` ssbssa at sourceware dot org
2023-01-24 19:02 ` ssbssa at sourceware dot org
2023-01-24 19:02 ` ssbssa at sourceware dot org
2023-01-24 19:03 ` ssbssa at sourceware dot org
2023-01-24 19:04 ` ssbssa at sourceware dot org
2023-01-24 19:07 ` tromey at sourceware dot org
2023-01-30 22:16 ` tromey at sourceware dot org [this message]
2023-01-30 23:22 ` tromey at sourceware dot org
2023-01-31  1:46 ` tromey at sourceware dot org
2023-01-31  2:04 ` tromey at sourceware dot org
2023-01-31 18:29 ` ssbssa at sourceware dot org
2023-02-11  1:13 ` tromey at sourceware dot org
2023-02-27 22:56 ` cvs-commit at gcc dot gnu.org
2023-02-27 22:57 ` tromey at sourceware dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30044-4717-nnSN7XZaPy@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).