[Bug tui/30056] double free when using reverse-search for a previous command and Ctrl-C

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30056

--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
Alternatively, we can regard this as a multibyte problem:
...
diff --git a/readline/readline/mbutil.c b/readline/readline/mbutil.c
index dc62b4cc24d..7da3ff17bb5 100644
--- a/readline/readline/mbutil.c
+++ b/readline/readline/mbutil.c
@@ -363,7 +363,7 @@ _rl_get_char_len (char *src, mbstate_t *ps)

   /* Look at no more than MB_CUR_MAX characters */
   l = (size_t)strlen (src);
-  if (_rl_utf8locale && l > 0 && UTF8_SINGLEBYTE(*src))
+  if (_rl_utf8locale && l >= 0 && UTF8_SINGLEBYTE(*src))
     tmp = (*src != 0) ? 1 : 0;
   else
     {
...

For "right arrow", tui_getc returns 0 and expects readline to treat it as a
nop.
However, readline treats it as the first part of a multi-byte character.  The
patch above fixes this, and allows it to be recognized as UTF8_SINGLEBYTE.

Consequently, we have a different call stack when ^C hit us, and the problem
doesn't trigger.

-- 
You are receiving this mail because:
You are on the CC list for the bug.