public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug tui/30056] double free when using reverse-search for a previous command and Ctrl-C
Date: Tue, 23 May 2023 09:53:55 +0000	[thread overview]
Message-ID: <bug-30056-4717-wttrtICsrK@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30056-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=30056

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
The simplest way of fixing this is:
...
diff --git a/readline/readline/isearch.c b/readline/readline/isearch.c
index 080ba3cbb9c..407c8b61543 100644
--- a/readline/readline/isearch.c
+++ b/readline/readline/isearch.c
@@ -882,7 +882,8 @@ _rl_isearch_callback (_rl_search_cxt *cxt)
   int c, r;

   c = _rl_search_getchar (cxt);
-  /* We might want to handle EOF here */
+  if (c == EOF)
+    return 1;
   r = _rl_isearch_dispatch (cxt, cxt->lastc);

   return (r <= 0) ? _rl_isearch_cleanup (cxt, r) : 0;
...
but the question is if that sometimes skips _rl_isearch_cleanup while it
shouldn't.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2023-05-23  9:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-26 17:47 [Bug tui/30056] New: " etesta at undo dot io
2023-01-27  3:04 ` [Bug tui/30056] " sam at gentoo dot org
2023-01-28 20:00 ` ssbssa at sourceware dot org
2023-05-23  8:38 ` vries at gcc dot gnu.org
2023-05-23  9:53 ` vries at gcc dot gnu.org [this message]
2023-05-23 10:29 ` vries at gcc dot gnu.org
2023-05-23 11:50 ` vries at gcc dot gnu.org
2023-05-23 15:06 ` vries at gcc dot gnu.org
2023-05-23 16:06 ` vries at gcc dot gnu.org
2023-05-24 14:11 ` vries at gcc dot gnu.org
2023-05-28  8:17 ` cvs-commit at gcc dot gnu.org
2023-05-28  8:27 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30056-4717-wttrtICsrK@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).