[Bug build/30108] gdb info docs fail to build when configured --with-system-readlne

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30108

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The gdb-13-branch branch has been updated by Keith Seitz
<kseitz@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c594b6f7d5dd50bc0ae3b0f15b556bfe592893bb

commit c594b6f7d5dd50bc0ae3b0f15b556bfe592893bb
Author: Keith Seitz <keiths@redhat.com>
Date:   Mon Feb 13 06:14:40 2023 -0800

    Fix doc build dependencies for --with-system-readline

    PR build/30108 concerns building gdb documentation with
    --with-sytem-readline.  If the in-tree readline directory is
    missing, though, the docs will fail to build:

    make[4]: Entering directory
'/home/keiths/work/readline-doc-issue/linux/gdb/doc'
    make[4]: *** No rule to make target
'../../../src/gdb/doc/../../readline/readline/doc/rluser.texi', needed by
'gdb.info'.  Stop.

    The listed file (and hsuser.texi) are conditionally included by
gdb.texinfo.
    When system readline is used, gdb/configure.ac will leave
    READLINE_TEXI_INCFLAGS empty, causing doc/Makefile.in to output a line to
    $BUILD/doc/GDBvn.texi with "@set SYSTEM_READLINE".  This surpresses the
    inclusion of the missing files. They are not needed or used in this
    scenario.

    However, GDB_DOC_SOURCE_INCLUDES always lists these two files as
dependencies,
    thus provoking the build error whenever readline/ is missing.

    This patch fixes this by creating (essentially) a conditional setting of
the
    dependencies to be included from readline.

-- 
You are receiving this mail because:
You are on the CC list for the bug.