[Bug build/30108] gdb info docs fail to build when configured --with-system-readlne

["keiths at redhat dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30108

Keith Seitz <keiths at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |keiths at redhat dot com
           Assignee|unassigned at sourceware dot org   |keiths at redhat dot com

--- Comment #1 from Keith Seitz <keiths at redhat dot com> ---
(In reply to Matthias Klose from comment #0)
> this seems to be different than #27808. with --with-system-readline
> configured, the build fails because it cannot find the readline includes. 
> These are always taken from the source tree, this should not be dependent on
> this configuration option.
> 
> seen on both the 13 branch and trunk. proposed patch:

Thanks for the report! I've confirmed this locally on origin/master.

> --- a/gdb/configure.ac
> +++ b/gdb/configure.ac
> @@ -590,7 +590,7 @@ if test "$with_system_readline" = yes; t
>    READLINE=-lreadline
>    READLINE_DEPS=
>    READLINE_CFLAGS=
> -  READLINE_TEXI_INCFLAG=
> +  READLINE_TEXI_INCFLAG='-I $(READLINE_DIR)'
>  else
>    READLINE='$(READLINE_DIR)/libreadline.a'
>    READLINE_DEPS='$(READLINE)'

I don't think this is really what we want to do. As mentioned in build/27808,
gdb.texinfo contains markers which should prevent these from being needed. The
real issue is that doc/Makefile.in:GDB_DOC_SOURCE_INCLUDES unconditionally
includes
the readline texi files, and it should not.

I have an alternate patch which I am testing and will propose to the mailing
list (where all patches are discussed and reviewed).

Thank you for bringing this to our attention!

-- 
You are receiving this mail because:
You are on the CC list for the bug.