[Bug build/30114] New: Add valgrind annotations to obstack

[Bug build/30114] New: Add valgrind annotations to obstack

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30114

            Bug ID: 30114
           Summary: Add valgrind annotations to obstack
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: tromey at sourceware dot org
  Target Milestone: ---

https://sourceware.org/bugzilla/show_bug.cgi?id=25479#c7 points out
that valgrind annotations could be added to the obstack code,
and then we could detect buffer overruns there as well.

 http://valgrind.org/docs/manual/mc-manual.html#mc-manual.mempools

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30114] Add valgrind annotations to obstack

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30114

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sam at gentoo dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30114] Add valgrind annotations to obstack

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30114

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
I wonder though if this could be done in libc first, or maybe gnulib.
And perhaps the libiberty copy should be sync'd with one of those.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30114] Add valgrind annotations to obstack

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30114

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
There are also ASAN annotations available.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30114] Add valgrind annotations to obstack

[simon.marchi at polymtl dot ca]

https://sourceware.org/bugzilla/show_bug.cgi?id=30114

Simon Marchi <simon.marchi at polymtl dot ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.marchi at polymtl dot ca

--- Comment #3 from Simon Marchi <simon.marchi at polymtl dot ca> ---
(In reply to Tom Tromey from comment #2)
> There are also ASAN annotations available.

I suppose you are talking about:

https://github.com/google/sanitizers/wiki/AddressSanitizerManualPoisoning

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30114] Add valgrind annotations to obstack

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30114

--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
(In reply to Simon Marchi from comment #3)

> I suppose you are talking about:

Yes, thanks for the link.

It would also be good to instrument objalloc, which is used by BFD.
For that one, maybe in the sanitizer case, every allocation could
just be done in a new chunk.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30114] Add valgrind annotations to obstack

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30114

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://sourceware.org/bugz
                   |                            |illa/show_bug.cgi?id=25479

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30114] Add valgrind annotations to obstack

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30114

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=116246

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30114] Add valgrind annotations to obstack

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30114

--- Comment #5 from Sam James <sam at gentoo dot org> ---
On the GCC side, I noted
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116246#c1):
> We should check if we can use the (extended) malloc attributes as
> well. I imagine there's a few missing parts for that in libiberty.
> gnulib does not have these for its obstack but it does for e.g.
> bitset_obstack_alloc which is based on obstack.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30114] Add valgrind annotations to obstack

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30114

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at klomp dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30114] Add valgrind annotations to obstack

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30114

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dmalcolm at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.