[Bug record/30169] New: FAIL: gdb.btrace/reconnect.exp: first: info record

[Bug record/30169] New: FAIL: gdb.btrace/reconnect.exp: first: info record

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30169

            Bug ID: 30169
           Summary: FAIL: gdb.btrace/reconnect.exp: first: info record
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: record
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

With current trunk, I ran into:
...
(gdb) PASS: gdb.btrace/reconnect.exp: first: stepi 19
info record^M
Active record target: record-btrace^M
Recording format: Intel Processor Trace.^M
Buffer size: 16kB.^M
warning: while parsing btrace: not well-formed (invalid token)^M
Error parsing branch trace.^M
(gdb) FAIL: gdb.btrace/reconnect.exp: first: info record
...
and:
...
(gdb) info record^M
Active record target: record-btrace^M
Recording format: Intel Processor Trace.^M
Buffer size: 16kB.^M
warning: while parsing btrace: not well-formed (invalid token)^M
Error parsing branch trace.^M
(gdb) FAIL: gdb.btrace/reconnect.exp: second: info record
...

I haven't tried to reproduce it yet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug record/30169] FAIL: gdb.btrace/reconnect.exp: first: info record

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30169

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |markus.t.metzger at intel dot com

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
Is this another instance of the problem we've added xfailing for in
gdb.python/py-record-btrace.exp ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug record/30169] FAIL: gdb.btrace/reconnect.exp: first: info record

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30169

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #0)
> I haven't tried to reproduce it yet.

And, it does:
...
FAIL: gdb.btrace/reconnect.exp: first: info record
FAIL: gdb.btrace/reconnect.exp: second: info record
...

FWIW, this is with --with-intel-pt, at commit bb87a06 ("sideband: fix
-Wextra-semi-stmt warning").

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug record/30169] FAIL: gdb.btrace/reconnect.exp: first: info record

[markus.t.metzger at intel dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30169

--- Comment #3 from Markus Metzger <markus.t.metzger at intel dot com> ---
(In reply to Tom de Vries from comment #1)
> Is this another instance of the problem we've added xfailing for in
> gdb.python/py-record-btrace.exp ?

Doesn't look related to me.  This one is about parsing the XML.  I can
reproduce it on my system.  Looks like a regression to me.  Bisecting...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug record/30169] FAIL: gdb.btrace/reconnect.exp: first: info record

[markus.t.metzger at intel dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30169

--- Comment #4 from Markus Metzger <markus.t.metzger at intel dot com> ---
(In reply to Markus Metzger from comment #3)
> (In reply to Tom de Vries from comment #1)
> > Is this another instance of the problem we've added xfailing for in
> > gdb.python/py-record-btrace.exp ?
> 
> Doesn't look related to me.  This one is about parsing the XML.  I can
> reproduce it on my system.  Looks like a regression to me.  Bisecting...

873a185be258ad2552b9579005852815b4da5baf is the first bad commit
commit 873a185be258ad2552b9579005852815b4da5baf
Author: Tom Tromey <tom@tromey.com>
Date:   Fri Dec 16 07:56:57 2022 -0700

    Don't use struct buffer in handle_qxfer_btrace

    This changes handle_qxfer_btrace and handle_qxfer_btrace_conf, in
    gdbserver, to use std::string rather than struct buffer.

 gdbserver/linux-low.cc | 72 +++++++++++++++++++++++++-------------------------
 gdbserver/linux-low.h  |  4 +--
 gdbserver/server.cc    | 32 +++++++++++-----------
 gdbserver/target.cc    |  6 ++---
 gdbserver/target.h     |  9 +++----
 5 files changed, 61 insertions(+), 62 deletions(-)
bisect found first bad commit

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug record/30169] FAIL: gdb.btrace/reconnect.exp: first: info record

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30169

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug record/30169] FAIL: gdb.btrace/reconnect.exp: first: info record

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30169

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org

--- Comment #5 from Tom Tromey <tromey at sourceware dot org> ---
Sorry about that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug record/30169] FAIL: gdb.btrace/reconnect.exp: first: info record

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30169

--- Comment #6 from Tom Tromey <tromey at sourceware dot org> ---
This one works for me, do I need to do something else?

# of expected passes            10

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug record/30169] FAIL: gdb.btrace/reconnect.exp: first: info record

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30169

--- Comment #7 from Tom Tromey <tromey at sourceware dot org> ---
I didn't have libipt installed :(

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug record/30169] FAIL: gdb.btrace/reconnect.exp: first: info record

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30169

--- Comment #8 from Tom Tromey <tromey at sourceware dot org> ---
https://inbox.sourceware.org/gdb-patches/20230301014551.2840647-1-tom@tromey.com/T/#u

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug record/30169] FAIL: gdb.btrace/reconnect.exp: first: info record

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30169

--- Comment #9 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8b2d5ef8d41e8da46d8b138ea7d7fe3eb5d4a221

commit 8b2d5ef8d41e8da46d8b138ea7d7fe3eb5d4a221
Author: Tom Tromey <tom@tromey.com>
Date:   Tue Feb 28 18:43:01 2023 -0700

    Fix btrace regression

    Tom de Vries pointed out that my earlier patch:

        commit 873a185be258ad2552b9579005852815b4da5baf
        Date:   Fri Dec 16 07:56:57 2022 -0700

            Don't use struct buffer in handle_qxfer_btrace

    regressed gdb.btrace/reconnect.exp.  I didn't notice this because I
    did not have libipt installed.

    This patch fixes the bug.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30169
    Tested-By: Bruno Larsen <blarsen@redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug record/30169] FAIL: gdb.btrace/reconnect.exp: first: info record

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30169

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.1
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #10 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.