public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "tromey at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/30201] New: remove reread_symbols
Date: Sun, 05 Mar 2023 17:40:32 +0000	[thread overview]
Message-ID: <bug-30201-4717@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=30201

            Bug ID: 30201
           Summary: remove reread_symbols
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: symtab
          Assignee: unassigned at sourceware dot org
          Reporter: tromey at sourceware dot org
  Target Milestone: ---

In

commit 9d428aae67a67087959822b0ffd81f7df96218c7
Author: Simon Marchi <simon.marchi@efficios.com>
Date:   Wed May 20 15:44:24 2020 -0400

    gdb: reset/recompute objfile section offsets in reread_symbols



Simon mentions:

    I don't really like the approach taken by reread_symbols, trying to
    reset everything manually on the objfile object, instead of, for
    example, creating a new one from scratch.  But I don't know enough yet
    to propose a better solution.

Ages ago, Jan had a patch to remove reread_symbols in favor of
doing exactly this.

This should be reimplemented.  The current approach is just bad.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

                 reply	other threads:[~2023-03-05 17:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30201-4717@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).