[Bug gdb/30286] New: Build error in split-name.h macro DOT

[Bug gdb/30286] New: Build error in split-name.h macro DOT

[lu.xinyu0121 at foxmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30286

            Bug ID: 30286
           Summary: Build error in split-name.h macro DOT
           Product: gdb
           Version: 3.0
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: gdb
          Assignee: unassigned at sourceware dot org
          Reporter: lu.xinyu0121 at foxmail dot com
  Target Milestone: ---

When I build gdb in Mac OS 13.2.1 (22D68), it report error here.
The macro DOT is conflate with enum split_style::DOT. Maybe we 
should replace one of the

./split-name.h:34:3: error: expected identifier
  DOT,
  ^
m2-exp.c:163:13: note: expanded from macro 'DOT'
#define DOT 302
            ^
In file included from m2-exp.y:42:
In file included from ./language.h:26:
./symtab.h:308:23: error: expected unqualified-id
        style = split_style::DOT;
                             ^
m2-exp.c:163:13: note: expanded from macro 'DOT'
#define DOT 302

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/30286] Build error in split-name.h macro DOT

[lu.xinyu0121 at foxmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30286

Xinyu Lu <lu.xinyu0121 at foxmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lu.xinyu0121 at foxmail dot com
            Version|3.0                         |HEAD

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/30286] Build error in split-name.h macro DOT

[simon.marchi at polymtl dot ca]

https://sourceware.org/bugzilla/show_bug.cgi?id=30286

Simon Marchi <simon.marchi at polymtl dot ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.marchi at polymtl dot ca

--- Comment #1 from Simon Marchi <simon.marchi at polymtl dot ca> ---
On Linux, my generated m2-exp.c also contains a `#define DOT 302`, and I don't
see that problem.  Out of curiosity, which bison/yacc tool version is used in
your build to convert m2-exp.y to m2-exp.c?  Can you attach the generated
m2-exp.c file?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30286] Build error in split-name.h macro DOT

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30286

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|gdb                         |build
                 CC|                            |tromey at sourceware dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30286] Build error in split-name.h macro DOT

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30286

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vries at gcc dot gnu.org

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
Another report of this PR here (
https://sourceware.org/pipermail/gdb/2023-August/050862.html ), mentioning GNU
Bison 2.3.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30286] Build error in split-name.h macro DOT

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30286

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
Bison 2.3, released in 2006, with many releases after...
maybe this is another one of those "Apple hates GPLv3" things?
I'd suggest trying to build with a bison from brew.  However
if we know that 2.3 works otherwise, I guess it is pretty
easy to rename split_style::DOT.
But -- do we know this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30286] Build error in split-name.h macro DOT

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30286

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-09-12
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |WAITING

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30286] Build error in split-name.h macro DOT

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30286

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org
             Status|WAITING                     |NEW

--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
Sending a fix.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30286] Build error in split-name.h macro DOT

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30286

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=fe26aa95336c0ddec01b407b990caf2c758fd93f

commit fe26aa95336c0ddec01b407b990caf2c758fd93f
Author: Tom Tromey <tromey@adacore.com>
Date:   Thu Aug 31 07:33:34 2023 -0600

    Rename split_style::DOT

    This renames split_style::DOT, to avoid name clashes when building gdb
    with an old version of Bison (2.3, the version available on macOS).

    In particular the error looks like:

    ./split-name.h:34:3: error: expected identifier
      DOT,
      ^
    m2-exp.c:163:13: note: expanded from macro 'DOT'

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30286

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30286] Build error in split-name.h macro DOT

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30286

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.1
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.