[Bug tui/30290] New: [gdb/tui] tui unusable with editing off

[Bug tui/30290] New: [gdb/tui] tui unusable with editing off

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30290

            Bug ID: 30290
           Summary: [gdb/tui] tui unusable with editing off
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tui
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

- start gdb
- type "set editing off<enter>"
- type "tui enable<enter>"
- type "quit<enter>"

After entering tui, nothing happens.

The "quit" isn't echoed, and gdb hangs.

It's stuck in gdb_readline_no_editing_callback, waiting for a '\n', which never
comes because the <enter> at the end of the quit somehow produces a '\r'
instead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/30290] [gdb/tui] tui unusable with editing off

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30290

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
Created attachment 14790
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14790&action=edit
Tentative patch

Fixes:
- the hang
- echoing of keys while typing, including enter

Still doesn't do anything useful with say backspace, which does work with
editing off outside of tui.  I think that might be a raw vs cooked mode
terminal thing.

But at least it makes things workable at a very basic level.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/30290] [gdb/tui] tui unusable with editing off

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30290

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
Another thing to do here could be to refuse entering tui with editing off.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/30290] [gdb/tui] tui unusable with editing off

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30290

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
Submitted RFC:
https://sourceware.org/pipermail/gdb-patches/2023-March/198490.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.