public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug testsuite/30399] New: [gdb/testsuite] FAIL: gdb.ada/excep_handle.exp: continuing to first Constraint_Error exception handlers
@ 2023-04-28  7:41 vries at gcc dot gnu.org
  2023-04-29  4:43 ` [Bug testsuite/30399] " vries at gcc dot gnu.org
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: vries at gcc dot gnu.org @ 2023-04-28  7:41 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=30399

            Bug ID: 30399
           Summary: [gdb/testsuite] FAIL: gdb.ada/excep_handle.exp:
                    continuing to first Constraint_Error exception
                    handlers
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

For a testsuite run with a build without tui and ncurses and system readline, I
run into:
...
FAIL: gdb.ada/excep_handle.exp: continuing to first Constraint_Error exception
handlers
FAIL: gdb.ada/excep_handle.exp: continuing and stopping in Storage_Error
exception handlers
FAIL: gdb.ada/excep_handle.exp: continuing without stopping to Program_Error
exception handlers
FAIL: gdb.ada/excep_handle.exp: continuing without stopping to Storage_Error
exception handlers
FAIL: gdb.ada/excep_handle.exp: continuing to second Constraint_Error exception
handlers
FAIL: gdb.ada/excep_handle.exp: continuing to Program_Error exception handlers
...

First fail in more detail:
...
(gdb) PASS: gdb.ada/excep_handle.exp: insert catchpoint on all Ada exceptions
handlers
continue^M
Continuing.^M
^M
Catchpoint 2, exception at 0x00000000004020b6 in foo () at
/data/vries/gdb/binutils-gdb.git/gdb/testsuite/gdb.ada/exc\
ep_handle/foo.adb:26^M
26            when Constraint_Error =>^M
(gdb) FAIL: gdb.ada/excep_handle.exp: continuing to first Constraint_Error
exception handlers
...

Fixed by:
...
diff --git a/gdb/testsuite/gdb.ada/excep_handle.exp
b/gdb/testsuite/gdb.ada/excep_handle.exp
index f8a6ded2cdf..300fefc8291 100644
--- a/gdb/testsuite/gdb.ada/excep_handle.exp
+++ b/gdb/testsuite/gdb.ada/excep_handle.exp
@@ -69,7 +69,7 @@ gdb_test_multiple "catch handlers" $msg {
 # Continue.  The program should stop at first exception handling.

 gdb_test "continue" \
-         "Continuing\.$eol$catchpoint_constraint_error_msg$eol.*" \
+         "Continuing\.$eol$catchpoint_constraint_error_msg" \
          "continuing to first Constraint_Error exception handlers"

 # Resume the program's exception.
...

I'll do some other builds to see whether this has to do with one of the
disabled aspects.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug testsuite/30399] [gdb/testsuite] FAIL: gdb.ada/excep_handle.exp: continuing to first Constraint_Error exception handlers
  2023-04-28  7:41 [Bug testsuite/30399] New: [gdb/testsuite] FAIL: gdb.ada/excep_handle.exp: continuing to first Constraint_Error exception handlers vries at gcc dot gnu.org
@ 2023-04-29  4:43 ` vries at gcc dot gnu.org
  2023-04-29  5:14 ` vries at gcc dot gnu.org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: vries at gcc dot gnu.org @ 2023-04-29  4:43 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=30399

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
I did another build, with ncuses and tui and without system readline.

FAIL did reproduce.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug testsuite/30399] [gdb/testsuite] FAIL: gdb.ada/excep_handle.exp: continuing to first Constraint_Error exception handlers
  2023-04-28  7:41 [Bug testsuite/30399] New: [gdb/testsuite] FAIL: gdb.ada/excep_handle.exp: continuing to first Constraint_Error exception handlers vries at gcc dot gnu.org
  2023-04-29  4:43 ` [Bug testsuite/30399] " vries at gcc dot gnu.org
@ 2023-04-29  5:14 ` vries at gcc dot gnu.org
  2023-04-29  6:36 ` vries at gcc dot gnu.org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: vries at gcc dot gnu.org @ 2023-04-29  5:14 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=30399

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
I did my usual build, with ncurses and tui and system readline.

Still FAILs.

This may be fallout from "gdb/testsuite: stricter matching for gdb_test".

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug testsuite/30399] [gdb/testsuite] FAIL: gdb.ada/excep_handle.exp: continuing to first Constraint_Error exception handlers
  2023-04-28  7:41 [Bug testsuite/30399] New: [gdb/testsuite] FAIL: gdb.ada/excep_handle.exp: continuing to first Constraint_Error exception handlers vries at gcc dot gnu.org
  2023-04-29  4:43 ` [Bug testsuite/30399] " vries at gcc dot gnu.org
  2023-04-29  5:14 ` vries at gcc dot gnu.org
@ 2023-04-29  6:36 ` vries at gcc dot gnu.org
  2023-04-29  6:56 ` cvs-commit at gcc dot gnu.org
  2023-04-29  6:57 ` vries at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: vries at gcc dot gnu.org @ 2023-04-29  6:36 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=30399

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #2)
> This may be fallout from "gdb/testsuite: stricter matching for gdb_test".

Confirmed, starts failing at commit e2f620135d9 ("gdb/testsuite: change newline
patterns used in gdb_test").

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug testsuite/30399] [gdb/testsuite] FAIL: gdb.ada/excep_handle.exp: continuing to first Constraint_Error exception handlers
  2023-04-28  7:41 [Bug testsuite/30399] New: [gdb/testsuite] FAIL: gdb.ada/excep_handle.exp: continuing to first Constraint_Error exception handlers vries at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2023-04-29  6:36 ` vries at gcc dot gnu.org
@ 2023-04-29  6:56 ` cvs-commit at gcc dot gnu.org
  2023-04-29  6:57 ` vries at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-04-29  6:56 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=30399

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=bc752bfbd98b6c2b02d59ed0a6c7ca88fbf4e3e0

commit bc752bfbd98b6c2b02d59ed0a6c7ca88fbf4e3e0
Author: Tom de Vries <tdevries@suse.de>
Date:   Sat Apr 29 08:57:07 2023 +0200

    [gdb/testsuite] Fix gdb.ada/excep_handle.exp for updated gdb_test

    Test-case gdb.ada/excep_handle.exp fails since commit e2f620135d9
    ("gdb/testsuite: change newline patterns used in gdb_test"):
    ...
    (gdb) continue^M
    Continuing.^M
    ^M
    Catchpoint 2, exception at 0x00000000004020b6 in foo () at foo.adb:26^M
    26            when Constraint_Error =>^M
    (gdb) FAIL: gdb.ada/excep_handle.exp: continuing to first Constraint_Error
\
      exception handlers
    ...

    The output is supposed to be matched by:
    ...
    gdb_test "continue" \
             "Continuing\.$eol$catchpoint_constraint_error_msg$eol.*" \
             "continuing to first Constraint_Error exception handlers"
    ...
    but the $eol bit no longer matches due to the stricter matching introduced
    in aforementioned commit.

    Fix this by dropping the "$eol.*" bit.

    Tested on x86_64-linux.

    PR testsuite/30399
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30399

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug testsuite/30399] [gdb/testsuite] FAIL: gdb.ada/excep_handle.exp: continuing to first Constraint_Error exception handlers
  2023-04-28  7:41 [Bug testsuite/30399] New: [gdb/testsuite] FAIL: gdb.ada/excep_handle.exp: continuing to first Constraint_Error exception handlers vries at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2023-04-29  6:56 ` cvs-commit at gcc dot gnu.org
@ 2023-04-29  6:57 ` vries at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: vries at gcc dot gnu.org @ 2023-04-29  6:57 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=30399

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |14.1

--- Comment #5 from Tom de Vries <vries at gcc dot gnu.org> ---
Fixed by commit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-04-29  6:57 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-28  7:41 [Bug testsuite/30399] New: [gdb/testsuite] FAIL: gdb.ada/excep_handle.exp: continuing to first Constraint_Error exception handlers vries at gcc dot gnu.org
2023-04-29  4:43 ` [Bug testsuite/30399] " vries at gcc dot gnu.org
2023-04-29  5:14 ` vries at gcc dot gnu.org
2023-04-29  6:36 ` vries at gcc dot gnu.org
2023-04-29  6:56 ` cvs-commit at gcc dot gnu.org
2023-04-29  6:57 ` vries at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).