[Bug build/30450] New: Build failure (linux-low.cc:5393:45: error: expected ':' before ')' token) with musl-1.2.4

[Bug build/30450] New: Build failure (linux-low.cc:5393:45: error: expected ':' before ')' token) with musl-1.2.4

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30450

            Bug ID: 30450
           Summary: Build failure (linux-low.cc:5393:45: error: expected
                    ':' before ')' token) with musl-1.2.4
           Product: gdb
           Version: 13.1
            Status: NEW
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: sam at gentoo dot org
                CC: brobecke at sourceware dot org
  Target Milestone: ---

musl-1.2.4 drops LFS shims (see https://bugs.gentoo.org/903611#c0).

I get the following with musl-1.2.4:
```
[...]
x86_64-gentoo-linux-musl-g++     -I. -I. -I./../gdb/regformats -I./..
-I./../include -I./../gdb -I./../gnulib/import -I../gnulib/import -I./.. -I..  
-pthread -Wall -Wpointer-arith -Wno-unused -Wunused-value
-Wunused-variable -Wunused-function -Wno-switch -Wno-char-subscripts
-Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable
-Wno-sign-compare -Wno-error=maybe-uninitialized -Wno-mismatched-tags -Ws
uggest-override -Wimplicit-fallthrough=3 -Wduplicated-cond -Wshadow=local
-Wdeprecated-copy -Wdeprecated-copy-dtor -Wredundant-move
-Wmissing-declarations -Wstrict-null-sentinel -Wformat -Wformat-nonliteral
-DGDBSERVER -O2 -pipe -march=native -fdiagnostics-color=always
-frecord-gcc-switches -D_GLIBCXX_ASSERTIONS     -c -o linux-low.o -MT
linux-low.o -MMD -MP -MF ./.deps/linux-low.Tpo linux-low.cc
linux-low.cc: In function 'int proc_xfer_memory(CORE_ADDR, unsigned char*,
const gdb_byte*, int)':
linux-low.cc:5393:45: error: expected ':' before ')' token
 5393 |                  ? write (fd, writebuf, len));
      |                                             ^
      |                                             :
linux-low.cc:5393:45: error: expected primary-expression before ')' token
linux-low.cc:5393:45: error: expected ':' before ')' token
 5393 |                  ? write (fd, writebuf, len));
      |                                             ^
      |                                             :
linux-low.cc:5393:45: error: expected primary-expression before ')' token
make[2]: *** [Makefile:545: linux-low.o] Error 1
```

This is already fixed on master in
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=2e977d9901393ea1bacbe1896af0929e968bc811.

Could this be backported to the 13 branch? Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30450] Build failure (linux-low.cc:5393:45: error: expected ':' before ')' token) with musl-1.2.4

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30450

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The gdb-13-branch branch has been updated by Tom Tromey
<tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=186143c39ed1c619c222e194cb33b927768a9026

commit 186143c39ed1c619c222e194cb33b927768a9026
Author: Khem Raj <raj.khem@gmail.com>
Date:   Wed Feb 22 16:28:22 2023 -0800

    gdbserver/linux-low.cc: Fix a typo in ternary operator

    Signed-off-by: Khem Raj <raj.khem@gmail.com>
    (cherry picked from commit 2e977d9901393ea1bacbe1896af0929e968bc811)
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30450

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30450] Build failure (linux-low.cc:5393:45: error: expected ':' before ')' token) with musl-1.2.4

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30450

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.2
         Resolution|---                         |FIXED
                 CC|                            |tromey at sourceware dot org
             Status|NEW                         |RESOLVED

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/30450] Build failure (linux-low.cc:5393:45: error: expected ':' before ')' token) with musl-1.2.4

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30450

--- Comment #3 from Sam James <sam at gentoo dot org> ---
Thank you!

-- 
You are receiving this mail because:
You are on the CC list for the bug.