[Bug dap/30475] New: Implement StackFrameFormat

[Bug dap/30475] New: Implement StackFrameFormat

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30475

            Bug ID: 30475
           Summary: Implement StackFrameFormat
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: dap
          Assignee: unassigned at sourceware dot org
          Reporter: tromey at sourceware dot org
  Target Milestone: ---

DAP lets the client request some stack frame formatting
via the StackFrameFormat type and the supportsValueFormattingOptions
capability.  This isn't implemented in gdb, but should be.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30475] Implement StackFrameFormat

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30475

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://github.com/microsof
                   |                            |t/debug-adapter-protocol/is
                   |                            |sues/411

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30475] Implement StackFrameFormat

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30475

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
I have a patch, but still haven't written the test.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30475] Implement StackFrameFormat

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30475

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
https://sourceware.org/pipermail/gdb-patches/2023-November/203729.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30475] Implement StackFrameFormat

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30475

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1920148904fe5ca0035c1addf2376f9ab13ffd3d

commit 1920148904fe5ca0035c1addf2376f9ab13ffd3d
Author: Tom Tromey <tromey@adacore.com>
Date:   Fri Oct 6 13:40:39 2023 -0600

    Handle StackFrameFormat in DAP

    DAP specifies a StackFrameFormat object that can be used to change how
    the "name" part of a stack frame is constructed.  While this output
    can already be done in a nicer way (and also letting the client choose
    the formatting), nevertheless it is in the spec, so I figured I'd
    implement it.

    While implementing this, I discovered that the current code does not
    correctly preserve frame IDs across requests.  I rewrote frame
    iteration to preserve this, and it turned out to be simpler to combine
    these patches.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30475

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30475] Implement StackFrameFormat

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30475

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The gdb-14-branch branch has been updated by Tom Tromey
<tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=45b2be661868f7e2b3628285362e699cb6e09266

commit 45b2be661868f7e2b3628285362e699cb6e09266
Author: Tom Tromey <tromey@adacore.com>
Date:   Fri Oct 6 13:40:39 2023 -0600

    Handle StackFrameFormat in DAP

    DAP specifies a StackFrameFormat object that can be used to change how
    the "name" part of a stack frame is constructed.  While this output
    can already be done in a nicer way (and also letting the client choose
    the formatting), nevertheless it is in the spec, so I figured I'd
    implement it.

    While implementing this, I discovered that the current code does not
    correctly preserve frame IDs across requests.  I rewrote frame
    iteration to preserve this, and it turned out to be simpler to combine
    these patches.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30475

    (cherry picked from commit 1920148904fe5ca0035c1addf2376f9ab13ffd3d)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30475] Implement StackFrameFormat

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30475

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |14.1
             Status|NEW                         |RESOLVED

--- Comment #5 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.