[Bug tui/30580] New: [gdb/tui] !HAVE_WBORDER and border-kind ascii and space

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30580

            Bug ID: 30580
           Summary: [gdb/tui] !HAVE_WBORDER and border-kind ascii and
                    space
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tui
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

The TUI sources contain a HAVE_WBORDER ifdef:
...
$ find gdb* -type f | xargs grep HAVE_WBORDER
gdb/config.in:#undef HAVE_WBORDER
gdb/tui/tui-wingeneral.c:#ifdef HAVE_WBORDER
...

I simulated the !HAVE_WBORDER case using:
...
-#ifdef HAVE_WBORDER
+#if 0
...
and realized that border-kind ascii and space still use the acs corners, which
looks funny.

With space border-kind:
...
┌                                  ┐

 [ No Source Available ]            

└                                  ┘
...

With ascii border-kind:
...
┌----------------------------------┐
|                                  |
|[ No Source Available ]           |
|                                  |
└----------------------------------┘
...

With the space border-kind there's a clear style break.

With the ascii border-kind, things look funny because the top corner elements
do not connect to the neighboring hline and vline elements, while the bottom
corner elements do connect to the neighboring vline elements, but not the hline
ones (at least, in my xterm).

Maybe the ascii and space border-kind values should be eliminated for the
!HAVE_WBORDER case.

-- 
You are receiving this mail because:
You are on the CC list for the bug.