public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
* [Bug dap/30681] New: gdb does not send "terminated" event @ 2023-07-25 12:47 tromey at sourceware dot org 2023-07-25 13:15 ` [Bug dap/30681] " vmakaev at gmail dot com ` (8 more replies) 0 siblings, 9 replies; 10+ messages in thread From: tromey at sourceware dot org @ 2023-07-25 12:47 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=30681 Bug ID: 30681 Summary: gdb does not send "terminated" event Product: gdb Version: HEAD Status: NEW Severity: normal Priority: P2 Component: dap Assignee: unassigned at sourceware dot org Reporter: tromey at sourceware dot org Target Milestone: --- This comes from https://sourceware.org/bugzilla/show_bug.cgi?id=30678#c1. gdb does not send the DAP "terminated" event. Apparently VSCode needs this to know that debugging is done. The DAP spec seems a little unclear on this point, as it seems to me that the exited event should have been enough... -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug dap/30681] gdb does not send "terminated" event 2023-07-25 12:47 [Bug dap/30681] New: gdb does not send "terminated" event tromey at sourceware dot org @ 2023-07-25 13:15 ` vmakaev at gmail dot com 2023-07-25 14:42 ` tromey at sourceware dot org ` (7 subsequent siblings) 8 siblings, 0 replies; 10+ messages in thread From: vmakaev at gmail dot com @ 2023-07-25 13:15 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=30681 Vladimir Makaev <vmakaev at gmail dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vmakaev at gmail dot com -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug dap/30681] gdb does not send "terminated" event 2023-07-25 12:47 [Bug dap/30681] New: gdb does not send "terminated" event tromey at sourceware dot org 2023-07-25 13:15 ` [Bug dap/30681] " vmakaev at gmail dot com @ 2023-07-25 14:42 ` tromey at sourceware dot org 2023-07-25 14:42 ` tromey at sourceware dot org ` (6 subsequent siblings) 8 siblings, 0 replies; 10+ messages in thread From: tromey at sourceware dot org @ 2023-07-25 14:42 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=30681 --- Comment #1 from Tom Tromey <tromey at sourceware dot org> --- Created attachment 15011 --> https://sourceware.org/bugzilla/attachment.cgi?id=15011&action=edit patch It isn't super clear to me exactly when this ought to be sent. This should work for ordinary cases at least. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug dap/30681] gdb does not send "terminated" event 2023-07-25 12:47 [Bug dap/30681] New: gdb does not send "terminated" event tromey at sourceware dot org 2023-07-25 13:15 ` [Bug dap/30681] " vmakaev at gmail dot com 2023-07-25 14:42 ` tromey at sourceware dot org @ 2023-07-25 14:42 ` tromey at sourceware dot org 2023-07-25 21:59 ` vmakaev at gmail dot com ` (5 subsequent siblings) 8 siblings, 0 replies; 10+ messages in thread From: tromey at sourceware dot org @ 2023-07-25 14:42 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=30681 Tom Tromey <tromey at sourceware dot org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|unassigned at sourceware dot org |tromey at sourceware dot org -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug dap/30681] gdb does not send "terminated" event 2023-07-25 12:47 [Bug dap/30681] New: gdb does not send "terminated" event tromey at sourceware dot org ` (2 preceding siblings ...) 2023-07-25 14:42 ` tromey at sourceware dot org @ 2023-07-25 21:59 ` vmakaev at gmail dot com 2023-07-26 15:38 ` tromey at sourceware dot org ` (4 subsequent siblings) 8 siblings, 0 replies; 10+ messages in thread From: vmakaev at gmail dot com @ 2023-07-25 21:59 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=30681 --- Comment #2 from Vladimir Makaev <vmakaev at gmail dot com> --- I've tested this patch. Seems to work correctly! Thanks! -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug dap/30681] gdb does not send "terminated" event 2023-07-25 12:47 [Bug dap/30681] New: gdb does not send "terminated" event tromey at sourceware dot org ` (3 preceding siblings ...) 2023-07-25 21:59 ` vmakaev at gmail dot com @ 2023-07-26 15:38 ` tromey at sourceware dot org 2023-07-26 15:58 ` tromey at sourceware dot org ` (3 subsequent siblings) 8 siblings, 0 replies; 10+ messages in thread From: tromey at sourceware dot org @ 2023-07-26 15:38 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=30681 --- Comment #3 from Tom Tromey <tromey at sourceware dot org> --- Thank you for this and your other testing. It's very helpful. https://sourceware.org/pipermail/gdb-patches/2023-July/201133.html -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug dap/30681] gdb does not send "terminated" event 2023-07-25 12:47 [Bug dap/30681] New: gdb does not send "terminated" event tromey at sourceware dot org ` (4 preceding siblings ...) 2023-07-26 15:38 ` tromey at sourceware dot org @ 2023-07-26 15:58 ` tromey at sourceware dot org 2023-07-27 15:27 ` tromey at sourceware dot org ` (2 subsequent siblings) 8 siblings, 0 replies; 10+ messages in thread From: tromey at sourceware dot org @ 2023-07-26 15:58 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=30681 Tom Tromey <tromey at sourceware dot org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |14.1 -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug dap/30681] gdb does not send "terminated" event 2023-07-25 12:47 [Bug dap/30681] New: gdb does not send "terminated" event tromey at sourceware dot org ` (5 preceding siblings ...) 2023-07-26 15:58 ` tromey at sourceware dot org @ 2023-07-27 15:27 ` tromey at sourceware dot org 2023-08-01 18:58 ` cvs-commit at gcc dot gnu.org 2023-08-01 18:58 ` tromey at sourceware dot org 8 siblings, 0 replies; 10+ messages in thread From: tromey at sourceware dot org @ 2023-07-27 15:27 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=30681 Tom Tromey <tromey at sourceware dot org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://github.com/microsof | |t/debug-adapter-protocol/is | |sues/150 -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug dap/30681] gdb does not send "terminated" event 2023-07-25 12:47 [Bug dap/30681] New: gdb does not send "terminated" event tromey at sourceware dot org ` (6 preceding siblings ...) 2023-07-27 15:27 ` tromey at sourceware dot org @ 2023-08-01 18:58 ` cvs-commit at gcc dot gnu.org 2023-08-01 18:58 ` tromey at sourceware dot org 8 siblings, 0 replies; 10+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2023-08-01 18:58 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=30681 --- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Tom Tromey <tromey@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=21db866dc69c481cd79b4d739c2170a7ef9b98fd commit 21db866dc69c481cd79b4d739c2170a7ef9b98fd Author: Tom Tromey <tromey@adacore.com> Date: Tue Jul 25 09:16:35 2023 -0600 Implement DAP 'terminated' event This implements the DAP 'terminated' event. Vladimir Makaev noticed that VSCode will not report the debug session as over unless this is sent. It's not completely clear when exactly this event ought to be sent. Here I've done it when the inferior exits. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30681 -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug dap/30681] gdb does not send "terminated" event 2023-07-25 12:47 [Bug dap/30681] New: gdb does not send "terminated" event tromey at sourceware dot org ` (7 preceding siblings ...) 2023-08-01 18:58 ` cvs-commit at gcc dot gnu.org @ 2023-08-01 18:58 ` tromey at sourceware dot org 8 siblings, 0 replies; 10+ messages in thread From: tromey at sourceware dot org @ 2023-08-01 18:58 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=30681 Tom Tromey <tromey at sourceware dot org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #5 from Tom Tromey <tromey at sourceware dot org> --- Fixed. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-08-01 18:58 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-07-25 12:47 [Bug dap/30681] New: gdb does not send "terminated" event tromey at sourceware dot org 2023-07-25 13:15 ` [Bug dap/30681] " vmakaev at gmail dot com 2023-07-25 14:42 ` tromey at sourceware dot org 2023-07-25 14:42 ` tromey at sourceware dot org 2023-07-25 21:59 ` vmakaev at gmail dot com 2023-07-26 15:38 ` tromey at sourceware dot org 2023-07-26 15:58 ` tromey at sourceware dot org 2023-07-27 15:27 ` tromey at sourceware dot org 2023-08-01 18:58 ` cvs-commit at gcc dot gnu.org 2023-08-01 18:58 ` tromey at sourceware dot org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).