[Bug gdb/30742] New: [gdb/help] help "maint print symbols"/"help maint print psymbols" mentions minimal symbols

[Bug gdb/30742] New: [gdb/help] help "maint print symbols"/"help maint print psymbols" mentions minimal symbols

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30742

            Bug ID: 30742
           Summary: [gdb/help] help "maint print symbols"/"help maint
                    print psymbols" mentions minimal symbols
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: minor
          Priority: P2
         Component: gdb
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

Consider the help texts of "maint print symbols":
...
(gdb) help maint print symbols
Print dump of current symbol definitions.
Usage: mt print symbols [-pc ADDRESS] [--] [OUTFILE]
       mt print symbols [-objfile OBJFILE] [-source SOURCE] [--] [OUTFILE]
Entries in the full symbol table are dumped to file OUTFILE,
or the terminal if OUTFILE is unspecified.
If ADDRESS is provided, dump only the file for that address.
If SOURCE is provided, dump only that file's symbols.
If OBJFILE is provided, dump only that file's minimal symbols.
...

and "maint print psymbols":
...
(gdb) help maint print psymbols
Print dump of current partial symbol definitions.
Usage: mt print psymbols [-objfile OBJFILE] [-pc ADDRESS] [--] [OUTFILE]
       mt print psymbols [-objfile OBJFILE] [-source SOURCE] [--] [OUTFILE]
Entries in the partial symbol table are dumped to file OUTFILE,
or the terminal if OUTFILE is unspecified.
If ADDRESS is provided, dump only the file for that address.
If SOURCE is provided, dump only that file's symbols.
If OBJFILE is provided, dump only that file's minimal symbols.
...

and "maint print msymbols":
...
(gdb) help maint print msymbols
Print dump of current minimal symbol definitions.
Usage: mt print msymbols [-objfile OBJFILE] [--] [OUTFILE]
Entries in the minimal symbol table are dumped to file OUTFILE,
or the terminal if OUTFILE is unspecified.
If OBJFILE is provided, dump only that file's minimal symbols.
(gdb) 
...

The phrase "dump only that file's minimal symbols" occurs three times, but only
"maint print msymbols" actually prints minimal symbols.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/30742] [gdb/help] help "maint print symbols"/"help maint print psymbols" mentions minimal symbols

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30742

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=980111642db44891500f53c12a939487d95deb68

commit 980111642db44891500f53c12a939487d95deb68
Author: Tom de Vries <tdevries@suse.de>
Date:   Mon Aug 14 18:27:02 2023 +0200

    [gdb] Fix maint print symbols/psymbols help text

    Consider the help text of "maint print symbols":
    ...
    (gdb) help maint print symbols
    Print dump of current symbol definitions.
    Usage: mt print symbols [-pc ADDRESS] [--] [OUTFILE]
           mt print symbols [-objfile OBJFILE] [-source SOURCE] [--] [OUTFILE]
    Entries in the full symbol table are dumped to file OUTFILE,
    or the terminal if OUTFILE is unspecified.
    If ADDRESS is provided, dump only the file for that address.
    If SOURCE is provided, dump only that file's symbols.
    If OBJFILE is provided, dump only that file's minimal symbols.
    ...
    and "maint print psymbols":
    ...
    (gdb) help maint print psymbols
    Print dump of current partial symbol definitions.
    Usage: mt print psymbols [-objfile OBJFILE] [-pc ADDRESS] [--] [OUTFILE]
           mt print psymbols [-objfile OBJFILE] [-source SOURCE] [--] [OUTFILE]
    Entries in the partial symbol table are dumped to file OUTFILE,
    or the terminal if OUTFILE is unspecified.
    If ADDRESS is provided, dump only the file for that address.
    If SOURCE is provided, dump only that file's symbols.
    If OBJFILE is provided, dump only that file's minimal symbols.
    ...

    The OBJFILE lines mistakingly mention minimal symbols.

    Fix this by reformulating as "dump only that object file's symbols".

    Also make the ADDRESS lines more clear by using the formulation: "dump only
    the symbols for the file with code at that address".

    Tested on x86_64-linux.

    Co-Authored-By: Eli Zaretskii <eliz@gnu.org>

    PR gdb/30742
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30742

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/30742] [gdb/help] help "maint print symbols"/"help maint print psymbols" mentions minimal symbols

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30742

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.1
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/30742] [gdb/help] help "maint print symbols"/"help maint print psymbols" mentions minimal symbols

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30742

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sam at gentoo dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.