public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org> To: gdb-prs@sourceware.org Subject: [Bug dap/30820] DAP GDB: Getting an error when bypassing "source" to breakpoint Date: Tue, 12 Sep 2023 16:37:10 +0000 [thread overview] Message-ID: <bug-30820-4717-a9A0bNoAQx@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-30820-4717@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=30820 --- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Tom Tromey <tromey@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f8ab027008863bd06513053ea9f84e1116c1cf73 commit f8ab027008863bd06513053ea9f84e1116c1cf73 Author: Tom Tromey <tromey@adacore.com> Date: Tue Sep 5 06:55:54 2023 -0600 Avoid spurious breakpoint-setting failure in DAP A user pointed out that if a DAP setBreakpoints request has a 'source' field in a SourceBreakpoint object, then the gdb DAP implementation will throw an exception. While SourceBreakpoint does not allow 'source' in the spec, it seems better to me to accept it. I don't think we should fully go down the "Postel's Law" path -- after all, we have the type-checker -- but at the same time, if we do send errors, they should be intentional and not artifacts of the implementation. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30820 -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2023-09-12 16:37 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-04 8:20 [Bug dap/30820] New: Error " artem.sokolovskii at qt dot io 2023-09-04 8:36 ` [Bug dap/30820] DAP GDB: Getting an error " artem.sokolovskii at qt dot io 2023-09-04 17:53 ` tromey at sourceware dot org 2023-09-05 8:00 ` artem.sokolovskii at qt dot io 2023-09-05 13:00 ` tromey at sourceware dot org 2023-09-05 13:55 ` artem.sokolovskii at qt dot io 2023-09-12 16:37 ` cvs-commit at gcc dot gnu.org [this message] 2023-09-12 16:37 ` tromey at sourceware dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-30820-4717-a9A0bNoAQx@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=gdb-prs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).