* [Bug build/30839] ODR warnings in ada-exp.c.tmp/c-exp.c.tmp
2023-09-11 20:02 [Bug build/30839] New: ODR warnings in ada-exp.c.tmp/c-exp.c.tmp sam at gentoo dot org
@ 2023-09-11 20:03 ` sam at gentoo dot org
2023-09-11 20:48 ` vries at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: sam at gentoo dot org @ 2023-09-11 20:03 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=30839
--- Comment #1 from Sam James <sam at gentoo dot org> ---
Created attachment 15108
--> https://sourceware.org/bugzilla/attachment.cgi?id=15108&action=edit
build.log.xz
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug build/30839] ODR warnings in ada-exp.c.tmp/c-exp.c.tmp
2023-09-11 20:02 [Bug build/30839] New: ODR warnings in ada-exp.c.tmp/c-exp.c.tmp sam at gentoo dot org
2023-09-11 20:03 ` [Bug build/30839] " sam at gentoo dot org
@ 2023-09-11 20:48 ` vries at gcc dot gnu.org
2023-09-11 21:17 ` sam at gentoo dot org
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: vries at gcc dot gnu.org @ 2023-09-11 20:48 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=30839
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |vries at gcc dot gnu.org
--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
Does adding a GDB_YY_REMAP line in gdb/yy-remap.h fix it?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug build/30839] ODR warnings in ada-exp.c.tmp/c-exp.c.tmp
2023-09-11 20:02 [Bug build/30839] New: ODR warnings in ada-exp.c.tmp/c-exp.c.tmp sam at gentoo dot org
2023-09-11 20:03 ` [Bug build/30839] " sam at gentoo dot org
2023-09-11 20:48 ` vries at gcc dot gnu.org
@ 2023-09-11 21:17 ` sam at gentoo dot org
2023-09-11 21:25 ` vries at gcc dot gnu.org
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: sam at gentoo dot org @ 2023-09-11 21:17 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=30839
--- Comment #3 from Sam James <sam at gentoo dot org> ---
(In reply to Tom de Vries from comment #2)
> Does adding a GDB_YY_REMAP line in gdb/yy-remap.h fix it?
Yeah, it does (this is with byacc, btw).
```
diff --git a/gdb/yy-remap.h b/gdb/yy-remap.h
index 33bee0fabdb..d0125b9ed45 100644
--- a/gdb/yy-remap.h
+++ b/gdb/yy-remap.h
@@ -85,6 +85,7 @@
#define yystacksize GDB_YY_REMAP (yystacksize)
#define yyvs GDB_YY_REMAP (yyvs)
#define yyvsp GDB_YY_REMAP (yyvsp)
+#define YYSTACKDATA GDB_YY_REMAP (YYSTACKDATA)
/* The following are common to all parsers. */
```
seems to work?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug build/30839] ODR warnings in ada-exp.c.tmp/c-exp.c.tmp
2023-09-11 20:02 [Bug build/30839] New: ODR warnings in ada-exp.c.tmp/c-exp.c.tmp sam at gentoo dot org
` (2 preceding siblings ...)
2023-09-11 21:17 ` sam at gentoo dot org
@ 2023-09-11 21:25 ` vries at gcc dot gnu.org
2023-09-12 10:50 ` vries at gcc dot gnu.org
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: vries at gcc dot gnu.org @ 2023-09-11 21:25 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=30839
--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
Cool. Then(In reply to Sam James from comment #3)
> (In reply to Tom de Vries from comment #2)
> > Does adding a GDB_YY_REMAP line in gdb/yy-remap.h fix it?
>
> Yeah, it does (this is with byacc, btw).
>
Nice, thanks. I guess you could commit as obvious.
> ```
> diff --git a/gdb/yy-remap.h b/gdb/yy-remap.h
> index 33bee0fabdb..d0125b9ed45 100644
> --- a/gdb/yy-remap.h
> +++ b/gdb/yy-remap.h
> @@ -85,6 +85,7 @@
> #define yystacksize GDB_YY_REMAP (yystacksize)
> #define yyvs GDB_YY_REMAP (yyvs)
> #define yyvsp GDB_YY_REMAP (yyvsp)
> +#define YYSTACKDATA GDB_YY_REMAP (YYSTACKDATA)
>
> /* The following are common to all parsers. */
>
> ```
> seems to work?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug build/30839] ODR warnings in ada-exp.c.tmp/c-exp.c.tmp
2023-09-11 20:02 [Bug build/30839] New: ODR warnings in ada-exp.c.tmp/c-exp.c.tmp sam at gentoo dot org
` (3 preceding siblings ...)
2023-09-11 21:25 ` vries at gcc dot gnu.org
@ 2023-09-12 10:50 ` vries at gcc dot gnu.org
2023-09-27 7:35 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: vries at gcc dot gnu.org @ 2023-09-12 10:50 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=30839
--- Comment #5 from Tom de Vries <vries at gcc dot gnu.org> ---
https://sourceware.org/pipermail/gdb-patches/2023-September/202351.html
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug build/30839] ODR warnings in ada-exp.c.tmp/c-exp.c.tmp
2023-09-11 20:02 [Bug build/30839] New: ODR warnings in ada-exp.c.tmp/c-exp.c.tmp sam at gentoo dot org
` (4 preceding siblings ...)
2023-09-12 10:50 ` vries at gcc dot gnu.org
@ 2023-09-27 7:35 ` cvs-commit at gcc dot gnu.org
2023-09-27 7:36 ` sam at gentoo dot org
2023-09-27 7:36 ` sam at gentoo dot org
7 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-09-27 7:35 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=30839
--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Sam James <sjames@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=df940f8bb348cf90445195ed4a34cddf9af634f6
commit df940f8bb348cf90445195ed4a34cddf9af634f6
Author: Sam James <sam@gentoo.org>
Date: Tue Sep 12 01:46:51 2023 +0100
gdb: Fix an ODR warning with byacc with GDB_YY_REMAP
With byacc, we get an ODR warning with YYSTACKDATA between ada-exp.c.tmp
and c-exp.c.tmp. Just include it in the list of symbols we rename.
PR gdb/30839
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30839
Approved-By: Tom de Vries <tdevries@suse.de>
Copyright-paperwork-exempt: yes
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug build/30839] ODR warnings in ada-exp.c.tmp/c-exp.c.tmp
2023-09-11 20:02 [Bug build/30839] New: ODR warnings in ada-exp.c.tmp/c-exp.c.tmp sam at gentoo dot org
` (5 preceding siblings ...)
2023-09-27 7:35 ` cvs-commit at gcc dot gnu.org
@ 2023-09-27 7:36 ` sam at gentoo dot org
2023-09-27 7:36 ` sam at gentoo dot org
7 siblings, 0 replies; 9+ messages in thread
From: sam at gentoo dot org @ 2023-09-27 7:36 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=30839
Sam James <sam at gentoo dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |14.1
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug build/30839] ODR warnings in ada-exp.c.tmp/c-exp.c.tmp
2023-09-11 20:02 [Bug build/30839] New: ODR warnings in ada-exp.c.tmp/c-exp.c.tmp sam at gentoo dot org
` (6 preceding siblings ...)
2023-09-27 7:36 ` sam at gentoo dot org
@ 2023-09-27 7:36 ` sam at gentoo dot org
7 siblings, 0 replies; 9+ messages in thread
From: sam at gentoo dot org @ 2023-09-27 7:36 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=30839
Sam James <sam at gentoo dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #7 from Sam James <sam at gentoo dot org> ---
Fixed for 14.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread