[Bug dap/31036] New: More type checking in DAP

[Bug dap/31036] New: More type checking in DAP

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31036

            Bug ID: 31036
           Summary: More type checking in DAP
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: dap
          Assignee: unassigned at sourceware dot org
          Reporter: tromey at sourceware dot org
  Target Milestone: ---

The DAP implementation tries to type-check the JSON objects
that are arriving.  This also helps keep the implementation
correct.

Some things, like a JSON "Source" object, aren't checked.
And some things are checked via an ad hoc procedure -- for
instance some breakpoint objects are checked by passing them
to a second no-op function just to get type-checking.

Perhaps this could be done more nicely by having a namedtuple
argument.  It would have to be an extension so that unexpected
keywords could be ignored.  And some layer would have to transform
from a JSON dict to a namedtuple.

There are also some spots that just have Sequence as the type,
these could be fixed.

Finally, maybe it would make sense to type-check the results of
DAP calls, as an added safety measure.  We had at least one bug
along these lines -- but the danger here is that the failures
may depend on the details of the inferior and not be visible in
ordinary testing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/31036] More type checking in DAP

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31036

--- Comment #1 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=674dea05e3bf2a4b68820adfa4f9e9510b4c1c8c

commit 674dea05e3bf2a4b68820adfa4f9e9510b4c1c8c
Author: Tom Tromey <tromey@adacore.com>
Date:   Mon Apr 29 12:46:17 2024 -0600

    Remove FIXME from DAP

    This patch removes one of the few DAP "FIXME" comments.  This
    particular comment is already covered by PR dap/31036.

-- 
You are receiving this mail because:
You are on the CC list for the bug.