[Bug testsuite/31201] New: [gdb/testsuite, stub-termcap] FAIL: gdb.base/wrap-line.exp: term=ansi: width-hard-coded: wrap (timeout)

[Bug testsuite/31201] New: [gdb/testsuite, stub-termcap] FAIL: gdb.base/wrap-line.exp: term=ansi: width-hard-coded: wrap (timeout)

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31201

            Bug ID: 31201
           Summary: [gdb/testsuite, stub-termcap] FAIL:
                    gdb.base/wrap-line.exp: term=ansi: width-hard-coded:
                    wrap (timeout)
           Product: gdb
           Version: unknown
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

With an build using stub-termcap.o, I run into:
...
FAIL: gdb.base/wrap-line.exp: term=ansi: width-hard-coded: wrap (timeout)
FAIL: gdb.base/wrap-line.exp: term=ansi: width-auto-detected: wrap (timeout)
FAIL: gdb.base/wrap-line.exp: term=xterm: width-hard-coded: $gdb_width ==
$readline_width
FAIL: gdb.base/wrap-line.exp: term=xterm: width-hard-coded: wrap (timeout)
FAIL: gdb.base/wrap-line.exp: term=xterm: width-auto-detected: $gdb_width ==
$readline_width
FAIL: gdb.base/wrap-line.exp: term=xterm: width-auto-detected: wrap (timeout)
...
and:
...
WARNING: timeout in accept_gdb_output
FAIL: gdb.tui/wrap-line.exp: width-hard-coded: cli: wrap
WARNING: timeout in accept_gdb_output
FAIL: gdb.tui/wrap-line.exp: width-hard-coded: cli: prompt after wrap
WARNING: timeout in accept_gdb_output
FAIL: gdb.tui/wrap-line.exp: width-auto-detected: cli: wrap
WARNING: timeout in accept_gdb_output
FAIL: gdb.tui/wrap-line.exp: width-auto-detected: cli: prompt after wrap
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31201] [gdb/testsuite, stub-termcap] FAIL: gdb.base/wrap-line.exp: term=ansi: width-hard-coded: wrap (timeout)

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31201

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
Easy way of reproducing this with a regular gdb build:
...
diff --git a/gdb/testsuite/gdb.base/wrap-line.exp
b/gdb/testsuite/gdb.base/wrap-line.exp
index b0931a3bbb8..fcb9def38d1 100644
--- a/gdb/testsuite/gdb.base/wrap-line.exp
+++ b/gdb/testsuite/gdb.base/wrap-line.exp
@@ -20,7 +20,7 @@
 require {!is_remote host}

 # Test both ansi (no auto-wrap) and xterm (auto-wrap).
-set terms {ansi xterm}
+set terms {ansi xterm dumb}

 # Fill line, assuming we start after the gdb prompt.
 proc fill_line { width } {
...
which gets us:
...
(gdb) PASS: gdb.base/wrap-line.exp: term=dumb: width-hard-coded: maint info
screen
PASS: gdb.base/wrap-line.exp: term=dumb: width-hard-coded: $gdb_width == [expr
$readline_width + 1]
PASS: gdb.base/wrap-line.exp: term=dumb: width-hard-coded: width
print 1^M
$1 = 1^M
(gdb)
78901234567890123456789012345678901234567890123456789012345678901234567^M<890123456789012345678901234567890123456789012345678
                       
^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H9WFAIL:
gdb.base/wrap-line.exp: term=dumb: width-hard-coded: wrap (timeout)
Quit^M
(gdb) PASS: gdb.base/wrap-line.exp: term=dumb: width-hard-coded: prompt after
wrap
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31201] [gdb/testsuite, stub-termcap] FAIL: gdb.base/wrap-line.exp: term=ansi: width-hard-coded: wrap (timeout)

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31201

--- Comment #2 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=250f1bbaf33e25da8b6beaf2e0e8a46c46127b1b

commit 250f1bbaf33e25da8b6beaf2e0e8a46c46127b1b
Author: Bernd Edlinger <bernd.edlinger@hotmail.de>
Date:   Mon Aug 12 17:32:44 2024 +0200

    [gdb/testsuite] Fix gdb.tui/wrap-line.exp with wrapping disabled

    There are a couple of ways that readline wrapping can be disabled:
    - using "set horizontal-scroll-mode on" in INPUTRC,
    - using a TERM setting like TERM=dumb, and
    - building gdb with stub-termcap.

    Using a trigger patch in default_gdb_init that adds
    "set horizontal-scroll-mode on" to INPUTRC:
    ...
    -    setenv INPUTRC [cached_file inputrc "set enable-bracketed-paste off"]
    +    setenv INPUTRC [cached_file inputrc "set enable-bracketed-paste
off\nset horizontal-scroll-mode on"]
    ...
    we can easily reproduce a failure in gdb.tui/wrap-line.exp mentioned in
    PR testsuite/31201 (which was reported for the stub-termcap case):
    ...
    WARNING: timeout in accept_gdb_output
    Screen Dump (size 50 columns x 24 rows, cursor at column 34, row 1):
        0 Quit
        1 <89012345678901234567890123456789W
        2
        ...
        23
    FAIL: gdb.tui/wrap-line.exp: width-hard-coded: cli: wrap
    ...

    Fix this by accepting the horizontal-scroll-mode style output.  We do
    this only when in CLI mode though, when in TUI wrapping works as before
    because it doesn't rely on readline.

    Tested on x86_64-linux.

    Co-Authored-By: Tom de Vries <tdevries@suse.de>

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31201

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31201] [gdb/testsuite, stub-termcap] FAIL: gdb.base/wrap-line.exp: term=ansi: width-hard-coded: wrap (timeout)

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31201

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #0)
> With an build using stub-termcap.o, I run into:
> ...
> FAIL: gdb.base/wrap-line.exp: term=ansi: width-hard-coded: wrap (timeout)
> FAIL: gdb.base/wrap-line.exp: term=ansi: width-auto-detected: wrap (timeout)
> FAIL: gdb.base/wrap-line.exp: term=xterm: width-hard-coded: $gdb_width ==
> $readline_width
> FAIL: gdb.base/wrap-line.exp: term=xterm: width-hard-coded: wrap (timeout)
> FAIL: gdb.base/wrap-line.exp: term=xterm: width-auto-detected: $gdb_width ==
> $readline_width
> FAIL: gdb.base/wrap-line.exp: term=xterm: width-auto-detected: wrap (timeout)
> ...

Fix submitted:
https://sourceware.org/pipermail/gdb-patches/2024-August/211018.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31201] [gdb/testsuite, stub-termcap] FAIL: gdb.base/wrap-line.exp: term=ansi: width-hard-coded: wrap (timeout)

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31201

--- Comment #4 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7ba8082f030c44b15616336f7dee7ee1df74ba21

commit 7ba8082f030c44b15616336f7dee7ee1df74ba21
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Sep 24 13:26:15 2024 +0200

    [gdb/cli] Show readline wrapping mode for maint info screen

    With the same trigger patch adding "set horizontal-scroll-mode on" to
INPUTRC
    as used in commit 250f1bbaf33 ("[gdb/testsuite] Fix gdb.tui/wrap-line.exp
with
    wrapping disabled"), we can easily reproduce a failure in
    gdb.tui/wrap-line.exp mentioned in PR testsuite/31201:
    ...
    (gdb)
78901234567890123456789012345678901234567890123456789012345678901234567^M<890123456789012345678901234567890123456789012345678
                       
^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H9WFAIL:
gdb.base/wrap-line.exp: term=ansi: width-hard-coded: wrap (timeout)
    ...

    The test-case expects wrapping, but that's disabled by
horizontal-scroll-mode.

    Add a new line to "maint info screen", that describes the current readline
    wrapping mode, and use it in the test-case to handle the different cases.

    The reported values for the wrapping mode are as follows.

    Unsupported because of running in batch mode:
    ...
    $ gdb -q -batch -ex "maint info screen"
    Readline wrapping mode: unsupported (gdb batch mode).
    ...

    Unsupported because the terminal is not capable to move the cursor up:
    ...
    $ TERM=dumb gdb -q -ex "maint info screen" -ex q
    Readline wrapping mode: unsupported (terminal is not Cursor Up capable).
    ...

    Disabled by horizontal-scroll-mode:
    ...
    $ grep horizontal-scroll-mode ~/.inputrc
    set horizontal-scroll-mode on
    $ gdb -q -ex "maint info screen" -ex q
    Readline wrapping mode: disabled (horizontal-scroll-mode).
    ...

    Wrap done by readline because terminal is not auto wrap capable:
    ...
    $ TERM=ansi gdb -q -ex "maint info screen" -ex q
    Readline wrapping mode: readline (terminal is not auto wrap capable, last
column reserved).
    ...

    Wrap done by terminal autowrap:
    ...
    $ TERM=xterm gdb -q -ex "maint info screen" -ex q
    Readline wrapping mode: terminal (terminal is auto wrap capable).
    ...

    Tested on x86_64-linux.

    Co-Authored-By: Bernd Edlinger <bernd.edlinger@hotmail.de>
    Approved-By: Tom Tromey <tom@tromey.com>

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31201

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31201] [gdb/testsuite, stub-termcap] FAIL: gdb.base/wrap-line.exp: term=ansi: width-hard-coded: wrap (timeout)

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31201

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |16.1
         Resolution|---                         |FIXED

--- Comment #5 from Tom de Vries <vries at gcc dot gnu.org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.