[Bug testsuite/31202] New: [gdb/testsuite, aarch64] "[PAC]" in backtrace

[Bug testsuite/31202] New: [gdb/testsuite, aarch64] "[PAC]" in backtrace

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31202

            Bug ID: 31202
           Summary: [gdb/testsuite, aarch64] "[PAC]" in backtrace
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

On aarch64-linux I'm running into a cluster of fails in these test-cases:
...
#rtf=gdb.base/annota1.exp                                                       
#rtf=gdb.cp/exception.exp                                                       
#rtf=gdb.dwarf2/entry-value-typedef.exp                                         
#rtf=gdb.mi/mi-syn-frame.exp                                                    
#rtf=gdb.mi/mi-catch-cpp-exceptions.exp                                         
#rtf=gdb.threads/pthread_cond_wait.exp                                          
#rtf=gdb.threads/tls.exp 
...

For example, in more detail:
...
gdb) PASS: gdb.cp/exception.exp: continue to first throw
backtrace^M
#0  0x0000fffff7ddcf30 in __cxa_throw () from /lib64/libstdc++.so.6^M
#1  0x0000000000410260 [PAC] in foo (i=20) at
/home/vries/gdb/src/gdb/testsuite/gdb.cp/exception.cc:23^M
#2  0x00000000004102b4 in main () at
/home/vries/gdb/src/gdb/testsuite/gdb.cp/exception.cc:45^M
(gdb) FAIL: gdb.cp/exception.exp: backtrace after first throw
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31202] [gdb/testsuite, aarch64] "[PAC]" in backtrace

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31202

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
https://sourceware.org/pipermail/gdb-patches/2024-January/205658.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31202] [gdb/testsuite, aarch64] "[PAC]" in backtrace

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31202

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kevinb at redhat dot com,
                   |                            |luis.machado at arm dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31202] [gdb/testsuite, aarch64] "[PAC]" in backtrace

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31202

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
Kevin, since you've mentioned you've got the same setup (m1 f39 asahi remix),
do you see the same FAILs?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31202] [gdb/testsuite, aarch64] "[PAC]" in backtrace

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31202

--- Comment #3 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2bcfdb758bb18e29cf6c0486c448bf78dbbc0c8a

commit 2bcfdb758bb18e29cf6c0486c448bf78dbbc0c8a
Author: Tom de Vries <tdevries@suse.de>
Date:   Thu Jan 4 13:42:45 2024 +0100

    [gdb/testsuite] Handle PAC marker

    On aarch64-linux, I run into:
    ...
    FAIL: gdb.base/annota1.exp: backtrace from shlibrary (timeout)
    ...
    due to the PAC marker showing up:
    ...
    ^Z^Zframe-address^M
    0x000000000041025c [PAC]^M
    ^Z^Zframe-address-end^M
    ...

    In the docs the marker is documented as follows:
    ...
    When GDB is debugging the AArch64 architecture, and the program is using
the
    v8.3-A feature Pointer Authentication (PAC), then whenever the link
register
    $lr is pointing to an PAC function its value will be masked.  When GDB
prints
    a backtrace, any addresses that required unmasking will be postfixed with
the
    marker [PAC].  When using the MI, this is printed as part of the addr_flags
    field.
    ...

    Update the test-case to allow the PAC marker.

    Likewise in a few other test-cases.

    While we're at it, rewrite the affected pattern pat_begin in annota1.exp
into
    a more readable form.  Likewise for the corresponding pat_end.

    Tested on aarch64-linux.

    Approved-By: Luis Machado <luis.machado@arm.com>

    PR testsuite/31202
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31202

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31202] [gdb/testsuite, aarch64] "[PAC]" in backtrace

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31202

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |15.1
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31202] [gdb/testsuite, aarch64] "[PAC]" in backtrace

[kevinb at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31202

--- Comment #5 from Kevin Buettner <kevinb at redhat dot com> ---
(In reply to Tom de Vries from comment #2)
> Kevin, since you've mentioned you've got the same setup (m1 f39 asahi
> remix), do you see the same FAILs?

I tested - prior to pulling in your fix - and do (did) see those failures.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31202] [gdb/testsuite, aarch64] "[PAC]" in backtrace

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31202

--- Comment #6 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Kevin Buettner from comment #5)
> (In reply to Tom de Vries from comment #2)
> > Kevin, since you've mentioned you've got the same setup (m1 f39 asahi
> > remix), do you see the same FAILs?
> 
> I tested - prior to pulling in your fix - and do (did) see those failures.

Thanks for testing and letting me know :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31202] [gdb/testsuite, aarch64] "[PAC]" in backtrace

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31202

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sam at gentoo dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.