public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/31203] [gdb] FAIL: gdb.base/kill-during-detach.exp: exit_p=true: checkpoint_p=true: python kill_and_detach()
Date: Tue, 09 Jan 2024 16:57:23 +0000 [thread overview]
Message-ID: <bug-31203-4717-z5hhjTRx7k@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31203-4717@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=31203
--- Comment #12 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Kevin Buettner from comment #11)
> (In reply to Tom de Vries from comment #10)
> > Not sure if this is the right place or way, but this fixes the FAIL:
> > ...
> > diff --git a/gdb/linux-fork.c b/gdb/linux-fork.c
> > index 1430ff89fa7..0d97ec1ba04 100644
> > --- a/gdb/linux-fork.c
> > +++ b/gdb/linux-fork.c
> > @@ -228,6 +228,8 @@ fork_load_infrun_state (struct fork_info *fp)
> > inferior_thread ()->set_stop_pc
> > (regcache_read_pc (get_thread_regcache (inferior_thread ())));
> > nullify_last_target_wait_ptid ();
> > + inferior_thread ()->set_executing (false);
> > + inferior_thread ()->set_resumed (false);
> >
> > /* Now restore the file positions of open file descriptors. */
> > if (fp->filepos)
> > ...
>
> There are multiple problems with linux-fork.c that need to be addressed
> at some point, but your patch looks reasonable to me.
Thanks for the pre-submission review, submitted (
https://sourceware.org/pipermail/gdb-patches/2024-January/205754.html ).
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2024-01-09 16:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-01 20:04 [Bug gdb/31203] New: " vries at gcc dot gnu.org
2024-01-01 20:04 ` [Bug gdb/31203] " vries at gcc dot gnu.org
2024-01-02 8:01 ` vries at gcc dot gnu.org
2024-01-02 8:36 ` vries at gcc dot gnu.org
2024-01-03 8:47 ` vries at gcc dot gnu.org
2024-01-03 10:31 ` vries at gcc dot gnu.org
2024-01-03 10:58 ` vries at gcc dot gnu.org
2024-01-04 4:37 ` kevinb at redhat dot com
2024-01-04 11:20 ` vries at gcc dot gnu.org
2024-01-04 11:21 ` vries at gcc dot gnu.org
2024-01-08 16:29 ` vries at gcc dot gnu.org
2024-01-08 19:05 ` kevinb at redhat dot com
2024-01-09 16:57 ` vries at gcc dot gnu.org [this message]
2024-01-11 9:12 ` cvs-commit at gcc dot gnu.org
2024-01-11 9:13 ` vries at gcc dot gnu.org
2024-01-11 9:15 ` vries at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-31203-4717-z5hhjTRx7k@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=gdb-prs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).